When logged into D7 as admin there are often two h2 elements with the text Management. One comes before the Management menu and one before the toolbar. This is a bit confusing. I think that it would better reflect the purpose of the list of links that form the toolbar if the text in its heading were changed to "Administrative Toolbar" or something similar.

I was going to roll a patch but I looked in toolbar.tpl.php for the heading and didn't find it. If someone can point out where the heading is generated I can roll a patch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Everett Zufelt’s picture

Status: Active » Needs review
FileSize
780 bytes

This patch changes the heading before the toolbar to "Administrative Toolbar". Not sure if this is the best place / method of making the change, but it works and affects nothing but the heading.

mgifford’s picture

It's actually $system_menus['management'] & not just 'management' however it seems that it's not spitting out anything more useful than that.

Why was this with a variable? Are there any other places this might be used? Is $system_menus['management'] used in any other contexts where hard coding this might be a problem?

Everett Zufelt’s picture

@mgifford

I'm not sure if it is used in other contexts, but I agree that it is best to modify it in a more global setting. Do you know where this is originally set?

Bojhan’s picture

Management is used as menu in the left sidebar too. Toolbar is somewhat of a weird replication of it, ideally there would only be one label indeed.

Dries’s picture

Status: Needs review » Needs work
+++ modules/toolbar/toolbar.module	1 Sep 2010 04:59:49 -0000
@@ -207,7 +207,7 @@
+    '#heading' => array('text' => t('Administrative Toolbar'), 'level' => 'h2', 'class' => 'element-invisible'),

We don't camel case every word in a title or sentence.

Everett Zufelt’s picture

Corrected heading from:

Administrative Toolbar

to

Administrative toolbar

Everett Zufelt’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, issue-898028-toolbar-heading-2.patch, failed testing.

Everett Zufelt’s picture

Will reroll this evening.

Everett Zufelt’s picture

Status: Needs work » Needs review
FileSize
810 bytes
Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

RTOTHEBC

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

David_Rothstein’s picture

Minor followup to remove the unused variable: #916488: Unused variable in toolbar_view()

Status: Fixed » Closed (fixed)
Issue tags: -Accessibility

Automatically closed -- issue fixed for 2 weeks with no activity.