When logged into D7 as admin there are often two h2 elements with the text Management. One comes before the Management menu and one before the toolbar. This is a bit confusing. I think that it would better reflect the purpose of the list of links that form the toolbar if the text in its heading were changed to "Administrative Toolbar" or something similar.
I was going to roll a patch but I looked in toolbar.tpl.php for the heading and didn't find it. If someone can point out where the heading is generated I can roll a patch.
Comment | File | Size | Author |
---|---|---|---|
#10 | issue-898028-toolbar-heading-3.patch | 810 bytes | Everett Zufelt |
#6 | issue-898028-toolbar-heading-2.patch | 796 bytes | Everett Zufelt |
#1 | issue-898028-toolbar-heading.patch | 780 bytes | Everett Zufelt |
Comments
Comment #1
Everett Zufelt CreditAttribution: Everett Zufelt commentedThis patch changes the heading before the toolbar to "Administrative Toolbar". Not sure if this is the best place / method of making the change, but it works and affects nothing but the heading.
Comment #2
mgiffordIt's actually $system_menus['management'] & not just 'management' however it seems that it's not spitting out anything more useful than that.
Why was this with a variable? Are there any other places this might be used? Is $system_menus['management'] used in any other contexts where hard coding this might be a problem?
Comment #3
Everett Zufelt CreditAttribution: Everett Zufelt commented@mgifford
I'm not sure if it is used in other contexts, but I agree that it is best to modify it in a more global setting. Do you know where this is originally set?
Comment #4
Bojhan CreditAttribution: Bojhan commentedManagement is used as menu in the left sidebar too. Toolbar is somewhat of a weird replication of it, ideally there would only be one label indeed.
Comment #5
Dries CreditAttribution: Dries commentedWe don't camel case every word in a title or sentence.
Comment #6
Everett Zufelt CreditAttribution: Everett Zufelt commentedCorrected heading from:
Administrative Toolbar
to
Administrative toolbar
Comment #7
Everett Zufelt CreditAttribution: Everett Zufelt commentedComment #9
Everett Zufelt CreditAttribution: Everett Zufelt commentedWill reroll this evening.
Comment #10
Everett Zufelt CreditAttribution: Everett Zufelt commentedComment #11
Bojhan CreditAttribution: Bojhan commentedRTOTHEBC
Comment #12
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD.
Comment #13
David_Rothstein CreditAttribution: David_Rothstein commentedMinor followup to remove the unused variable: #916488: Unused variable in toolbar_view()