Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Featured region should not extend the full width.
Somewhere along the way the div.section inner was removed and the section and clearfix classes applied to the div#featured container - this is wrong because then there is no inner wrapper to contain the width (in layout.css it is set to 960px).
The patch reinstates the .section inner DIV and adjusts the padding on #featured which also looks wrong (the padding top is huge, way to big when you add the margin/padding etc applied to block content).
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupal-bartik-896956-7.patch | 1.31 KB | tim.plunkett |
| bartik-featured-region.png | 90.3 KB | Jeff Burnz | |
| bartik-fix-featured-region.patch | 1.29 KB | Jeff Burnz | |
Comments
Comment #1
tim.plunkettUgh. The differences between having
#main-wrapper > #mainand#featured > .sectionand#footer-wrapper > .section > #footerare confusing and seemingly arbitrary.That said, this patch does fix the regression, and should go through.
Comment #2
Jeff Burnz CreditAttribution: Jeff Burnz commentedAgreed, the markup needs a good cleanup - there's a couple of other patches floating in the queue that try to get rid of some of the redundant section DIV's.
Needs an RTBC, maybe Jen should see it first because it adjusts the padding, which I am sure used to be more like I have it now.
Comment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedbartik-fix-featured-region.patch queued for re-testing.
Comment #4
reglogge CreditAttribution: reglogge commentedThis is long overdue and entirely correct.
Comment #5
Jeff Burnz CreditAttribution: Jeff Burnz commentedYep, and just as a side note Jen mentioned about this briefly to me at CPH DC, so she is well aware of the regression needing to be fixed - this should go through as its really ugly in its current state.
Comment #6
Jeff Burnz CreditAttribution: Jeff Burnz commentedbartik-fix-featured-region.patch queued for re-testing.
Comment #7
tim.plunkettAnother re-roll because of #660614: Remove #block-system-main dependency, fix font sizes, remove crufty CSS.
No actual changes, wait for green then commit.
Comment #8
reglogge CreditAttribution: reglogge commentedand green it is...
Comment #9
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #10
Jeff Burnz CreditAttribution: Jeff Burnz commentedAwesome sauce.