if (substr_count($info['php'], '.') < 2) {
  $php_required .= '.*';
}

$php_required is never initialized so the value is either ".*" or "" so the user message reads funny since there is an incorrect value (or none) placed in it.

CommentFileSizeAuthor
#1 894614-php-compatibility.patch710 bytesboombatower
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
FileSize
894614-php-compatibility.patch710 bytes
solotandem’s picture

solotandem CreditAttribution: solotandem commented
Status: Needs review » Reviewed & tested by the community

Makes sense.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

#1: 894614-php-compatibility.patch queued for re-testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Marked #806312: This module requires PHP version .* and is incompatible with PHP version as a duplicate of this issue since this one is RTBC.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Good catch, boombatower. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.