1. Open in new window setting no longer "opens in new window"
2. Printer-friendly URLs list is not checked yet printed output still shows the links.

Comments

jcnventura’s picture

Status: Active » Postponed (maintainer needs more info)

Hi,

In what browser are you getting 1.

As to 2, this has suffered a change now.. The per-content settings no longer apply to all nodes of this type, but instead work more as default settings for that node type. Which of the "Printer-friendly URLs list" boxes is not checked? The global one, content-specific or node-specific.

João

apmsooner’s picture

Firefox but i checked this morning and its popping up. Weird cause i cleared cache and everything yesterday but it still must have just been an issue on my end so mark that one okay. The printer-friendly urls list is showing up with settings checked off globally and per content type so that one is still an issue for me.

OldAccount’s picture

I have issue #2 as well, when I try to uncheck the "Printer-friendly URLs" box (on admin/settings/print/common) it says "File C:\web\htdocs/ is not readable by the web server" and doesn't save my changes. However, if I enter something valid (like sites\all\modules\print\css\print.css) in the Custom Stylesheet field, the Printer-friendly URL change will save.

jcnventura’s picture

apmsooner’s picture

I'm on 6.x-1.12, printer friendly urls output for me regardless of the settings.

ralphb’s picture

Status: Postponed (maintainer needs more info) » Active

Same here: No error messages when changing "printer-friendly URLs" settings, but links always show irregardless of actual value.

(In my particular case I'm using the Print button for system pages, more specifically some views.)

NaX’s picture

Title: Some settings don't work with newest update » Settings Open in new window and Printer-friendly URLs list don't
Priority: Normal » Major
Status: Active » Needs review

I just ran into the same problem and fixed it by changing it from return true; in _print_url_list_enabled to use the setting variable.

function _print_url_list_enabled($node, $format = PRINT_HTML_FORMAT) {
  if (!isset($node->type)) {    
    return variable_get('print_urls', PRINT_URLS_DEFAULT);
  }  
  // ...
}
msimanga’s picture

Title: Settings Open in new window and Printer-friendly URLs list don't » Path Setting

Looking at the page source I noticed the path to print.css was not complete. Below are two sample paths, one to the user.css and the other to print.css

<link type="text/css" rel="stylesheet" media="all" href="/mysite/modules/user/user.css?D" />
<link type='text/css' rel='stylesheet' media='all' href='sites/all/themes/mytheme/print.css' />

The first part with /mysite/ is missing the print.css URL.In the print module settings I added the missing folder to the path. Below are what I had before and after in the setting Stylesheet URL:
Before: %t/print.css
After: /mysite/%t/print.css

The path to print.css was correct the print styles worked fine in the print view. Hope this helps someone.

jcnventura’s picture

Status: Needs review » Fixed

Thanks for the patch NaX! I've committed it to git.

@msimanga: I can't reproduce that behaviour.. if you've got your site in a path, the module will add that to the URL.

jcnventura’s picture

Title: Path Setting » Settings Open in new window and Printer-friendly URLs list don't

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.