On all site install log messages I have been seeing:

Trying to get property of non-object provision.inc:57

The function in question (provision_get_base_url) calls:
$http_port = d()->web_server->http_port;

FWIW, the warning goes away after changing this line to read:
$http_port = d()->web_server['http_port'];

CommentFileSizeAuthor
#1 888194.patch749 bytesergonlogic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
FileSize
888194.patch749 bytes

patch attached

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Active » Needs review
omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Status: Needs review » Reviewed & tested by the community

The patch from #1 fixes the issue also for latest HEAD.
Marking as RTBC.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Are we solving the problem here or just hiding it?

In other cases in provision I am seeing things like

http/http.drush.inc:    $data['http_port'] = $this->server->http_port;

is web_server still valid? Maybe this is the issue here?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Reviewed & tested by the community » Fixed

Since neither d()->web_server->http_port nor d()->web_server['http_port'] return anything, and d()->server->http_port returns '80' on my system, I went with my gut instinct and made it that instead.

Fixed in git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 83bcf56 on prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by mig5: 
    #888194 - http_port was being fetched from web_server attribute instead...