Issues with the number of questions and questions set to always.

Would it be valid to say if the number of always questions > the "number of questions" value, increase the "number of questions" value to match the number of "always" questions and let the user know what we did?

This could potentially cut out the random questions, but I think that might OK.

Here is a first attempt at fixing this. This patch does the following:

• Removes the handling of quiz_questions form from the quiz_questions form.
• Renamed quiz_questions_execute to quiz_questions_submit so that it once again handles the submission of this page.
• Adds a new function for getting a count of the questions of a particular type ("always", "random, etc.) for a particular quiz.
• Adds logic to increase or decrease the number of questions based on the questions.
• Uses Nicholas' suggestions above to add one extra if there are any set to "random."
• Adds and indicator of how many questions the quiz currently is set to display.
• Updates hook_validate to set an error if the number of questions for a quiz is outside of the range.
• Valid range for a quiz is the number of questions set to "always" (+1 if there are any set to "random") to the total number of questions assigned to the quiz (always + random).

It would be great if drupal would send the user to the "add questions" page after initially creating a quiz, but my brain is too tired to make that happen right now. Otherwise this seems to do the job pretty well.

If you only have one random question defined, it would never show up. ie- With 10 "always" questions and 1 "random" question, 11 -1 = 10.

I guess I could check for random > 1 before subtracting one from the high range...

    // If we have random number, add one to the low range.
    if($anum_random > 0){
      $anum_always++;
    }
    // If we have more than one random number, lower the high range by one.
    if($anum_random > 1){
      $anum_total--;
    }

I was trying to avoid getting into a lotof tedious and un-intuitive logic, but that doesn't actually seem too
bad.

On the other hand, is it bad to force users to choose one less than the total number of questions? At the very least, it seems that the rules governing the range is complex enough now that I should update the help description of the "number of questions" field.

Here's a new version that just adds the rule that I posted above to the validation hook.

I did not update the help text on the number of fields form element because I was having a hard time describing the rules in a meaningful way without using a whole paragraph. I'm going to create a new issue to update the help text and add a note in there concerning the min and max values for this field.

If someone wants to give this the thumbs up, I'll start on the rest of the issues.

Nicholas gave me a thumbs up to commit this over IM.

Committed