Ok, so when configuring the date admin/config/regional/date-time labels are missing on the dates. I think it's set in theme_system_date_time_settings(), but only by removing 

unset($form['format'][$key]['#title']);

Was I able to add the label, but I couldn't make that label visible too.

CommentFileSizeAuthor
#12 ui_date_and_time_WTF_fixed.png80.56 KBbfroehle
#12 1014002-1-fix-column-of-invisible.patch923 bytesbfroehle
#11 ui_date_and_time_WTF.png85.38 KBbfroehle
#5 system_date_label_v2.patch858 bytesmgifford
#2 system_date_label_v1.patch812 bytesmgifford
screen-capture-66.png106.55 KBmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue tags: +Accessibility

tagging

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Active » Needs review
FileSize
system_date_label_v1.patch812 bytes

Ok, found the patch that works for this.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

It's the same approach used here http://drupal.org/node/884932#comment-3338098

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work 
+++ modules/system/system.admin.inc	17 Aug 2010 18:30:02 -0000
@@ -2029,7 +2029,7 @@ function theme_system_date_time_settings
+    $row[] = $form['format'][$key]['#title_display'] = 'invisible';

Not a fan of those double assignments. Let's split this up over multiple lines please. Thanks!

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs work » Needs review
FileSize
system_date_label_v2.patch858 bytes

Agreed that looks awkward. Bit better now that it's on two lines.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Needs review » Reviewed & tested by the community

It adressed Dries his point

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Yup. It's better now. Thanks.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

#5: system_date_label_v2.patch queued for re-testing.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bfroehle’s picture

bfroehle CreditAttribution: bfroehle commented
Status: Closed (fixed) » Needs work
FileSize
ui_date_and_time_WTF.png85.38 KB

This patch gives me a row of 'invisible'. That cannot possibly be correct.

bfroehle’s picture

bfroehle CreditAttribution: bfroehle commented
Status: Needs work » Needs review
FileSize
1014002-1-fix-column-of-invisible.patch923 bytes
ui_date_and_time_WTF_fixed.png80.56 KB

Here's a suggested patch with the corresponding UI change in the attached image.

bfroehle’s picture

bfroehle CreditAttribution: bfroehle commented
Title: Labels missing for date » Extra column of 'invisible' in date and time form
dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Title: Extra column of 'invisible' in date and time form » Labels missing for date
Status: Needs review » Reviewed & tested by the community

Yeah, splitting onto 2 lines is a good idea, since one of the assignments, namely to $rows[] should never have happened in the first place. ;)

I tested this manually and confirmed the screenshots. This is a serious UI WTF that we should fix before 7.0 ships.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Title: Labels missing for date » Extra column of 'invisible' in date and time form

Sorry, x-post on the title change. Status is still RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

that's great news! Thanks everyone! So this will be in the final release of D7?

Status: Fixed » Closed (fixed)
Issue tags: -Accessibility

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Accessibility

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.