Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
For consistency with other page elements (breadcrumb, navigation, etc.) I'd like too see the messages wrapped
in their own div, like in Bartik for example:
<?php if ($messages): ?>
<div id="messages"><div class="section clearfix">
<?php print $messages; ?>
</div></div> <!-- /.section, /#messages -->
<?php endif; ?>
At the moment if you don't override the page.tpl.php provided by system module the messages are the only elements not wrapped by a div with an id.
This would help with CSS only themes.
Comment | File | Size | Author |
---|---|---|---|
#1 | 882796_page.tpl_.php_.patch | 446 bytes | derjochenmeyer |
Comments
Comment #1
derjochenmeyer CreditAttribution: derjochenmeyer commentedIt is already possible to theme the messages with the div that gets added in theme_status_messages.
Attached patch however implements the suggestion made above.
Comment #2
lilou CreditAttribution: lilou commentedComment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedNot a bug and way to late. Core template review was over a year ago (so long ago I have forgotten when).
Comment #4
TR CreditAttribution: TR commented#1: 882796_page.tpl_.php_.patch queued for re-testing.
Comment #5
sunLovely.
Comment #6
catchThis will need documentation in the theme upgrade docs, tagging as such.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Moving to 7.x for Angie to consider.
Comment #8
webchickWhile this seems like a harmless enough fix, it would introduce a markup change in D7 themes, which could affect CSS-only themes. Since #1 has a workaround for D7, I'm inclined to keep this D8-only.
Marking back to 8.x-dev and "needs work" pending a http://drupal.org/node/add/changenotice node.
Comment #9
catchComment #10
webchickAnd since adding that summary is relatively easy, tagging as Novice.
Comment #11
derjochenmeyer CreditAttribution: derjochenmeyer commentedMy first Change record... Does this need more elaboration?
http://drupal.org/node/1294560
Comment #12
derjochenmeyer CreditAttribution: derjochenmeyer commentedComment #13
catchLooks good to me. Thanks!
Comment #15
xjm