theme_view : missing parameter ? [#88067]

looking at the code

function theme_view( $view_name, $limit = 0, $use_pager = false, $type = 'embed' ) {
  if ($view = views_get_view($view_name)) {
    return views_build_view($type, $view, $view_args, $use_pager, $limit);
  }
}

I don't understand where the $view_args param is supposed to come from ?
Shouldn't that be added as an additional argument of the theme_view function

Comment	File	Size	Author
#7	views.module_26.patch	2.2 KB	yched
#7
#3	views.module_25.patch	986 bytes	yched
#3
#2	views.module_24.patch	848 bytes	yched
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 8 October 2006 at 16:46

Yep, it should be passed in to theme_view. Patches accepted. [someone contributed this function as a patch].

File	Size
views.module_24.patch	848 bytes

I kept the order of the arguments in order not to break anything, but since theme_view is just a wrapper for views_build_view, it would probably make more sense to have the arguments in the same order for both functions...

Comment #3

yched CreditAttribution: yched commented 10 October 2006 at 17:27

File	Size
views.module_25.patch	986 bytes

Actually, I sort of reworked this theme_views function :
Currently, it only takes into account the parameters (limit, use pager) that are passed to the function, discarding the fact that the view already contains settings for these.
If no params are provided, the limit = 0 and pager = false are used (which is now quite a bad default - all nodes, no pager !), instead of the "inner" views values

So I think it makes more sense to have the params override the views default settings, and let the default settings apply if no arguments are provided.

I'll provide an update for the function documenttion if you agree with the patch.