comment.module has nasty inline styles for threaded comments [#87995]

Comment	File	Size	Author
	comment_37.patch	2.73 KB	merlinofchaos

Comment #1

Dries CreditAttribution: Dries commented 9 October 2006 at 07:27

Does this need fixing in CVS HEAD too? Looks like a good change.

Log in or register to post comments

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 9 October 2006 at 14:46

Version:

4.7.3

» x.y.z

Actually this patch was meant for HEAD and I clicked the wrong version; glad you pointed that out causing me to notice

That said, I think this patch should actually be for both 4.7.3 AND HEAD (and might even apply to both if we are lucky.)

Log in or register to post comments

Comment #3

Dries CreditAttribution: Dries commented 11 October 2006 at 13:18

Version:	x.y.z	» 4.7.3
Status:	Needs review	» Needs work

Committed to CVS HEAD. Not sure if this needs to be backported but I'll leave that up to killes.

The patch won't apply because comment.css does not exist in Drupal 4.7. Marking as 'code needs work'.

Thanks Earl.

Log in or register to post comments

Comment #4

ontwerpwerk CreditAttribution: ontwerpwerk commented 12 October 2006 at 12:09

I marked http://drupal.org/node/5072 as a duplicate of this...

by the way: +1 on removing inline CSS

Log in or register to post comments

Comment #5

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 14 October 2006 at 12:18

Version:	4.7.3	» x.y.z
Status:	Needs work	» Reviewed & tested by the community

We are running a site with Drupal 5.0 Trunk, and it is clear that comment.css is missing from the codebase (it does not exist on cvs.drupal.org either). Comment.css should be included in the repository. Ready to be comitted, since the code is here in the patch.