Embarassing.
The submit handler for the 'Manage fields' screen still alters the weight on all view modes, just like before 'Manage display' got their own per-view-mode reordering in #553298: Redesign the 'Manage Display' screen.
1) on admin/structure/types/manage/article/fields ('Manage fields'), drag 'body' at the bottom
2) on 'Manage display', drag 'body' at the bottom too
3) on 'Manage fields', drag 'body' at the top
4) visit 'Manage display' : 'body' is at the top...
Trivial patch.
Obviously, this only highlights that a very large part of the Field UI still has no tests, which I'm painfully aware of :-(.
I do intend to write a full fledge test suite, but am still buried with code work - currently #616240: Make Field UI screens extensible from contrib - part II, which I didn't even get a chance to touch for a week...
Comment | File | Size | Author |
---|---|---|---|
field_ui_reorder.patch | 696 bytes | yched | |
Comments
Comment #1
moshe weitzman CreditAttribution: moshe weitzman commentedOnly you, me, and Drieschick will ever know.
Comment #2
webchickHrm... :\
Ok... committed to HEAD.
This is the Nth time I've done this, though (committed a minor but obvious bug fix in Field UI, without tests behind it to keep it working). I'm really thinking #600544: Tests for Field UI should be escalated to critical. Doesn't have to be you who works on it, but someone certainly needs to. Put it at "major" for now.
Comment #3
BenK CreditAttribution: BenK commentedGreat to see this committed. Since I originally reported this issue on another thread, just want to keep track of this.
Thanks,
Ben
Comment #4
yched CreditAttribution: yched commented@BenK : Yes, forgot to credit the original report back to #857296: "Comment Fields" Not Displaying in Proper Order. Sorry about that.