Files and Images don't work in private filesystem mode [#867928]

When using a private filesystem, neither files nor images work, because file_get_file_references() is still severely broken.

#846296: file_file_download() only implements access checks for nodes and users tested part of file_get_file_references(), but not the part where the check is done across all the fields (ie. $field is NULL).

Comment	File	Size	Author
#5	867928-file-tests-d7.patch	3.12 KB	andypost
#5
#2	867928-file-private-downloads-broken.patch	905 bytes	Damien Tournoud
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 29 July 2010 at 02:31

This was noted in the original post of #846296: file_file_download() only implements access checks for nodes and users.

Comment #2

Damien Tournoud CreditAttribution: Damien Tournoud commented 29 July 2010 at 02:34

Status:

Active

» Needs review

File	Size
867928-file-private-downloads-broken.patch	905 bytes

The correct fix is simply, but we need a test of this.

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost commented 29 July 2010 at 15:34

Status:

Needs review

» Reviewed & tested by the community

Tested, works!

Comment #4

Dries CreditAttribution: Dries commented 30 July 2010 at 01:46

Priority:	Critical	» Normal
Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs tests

Committed to CVS HEAD but setting to 'needs work' because we still need a test.

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost commented 30 July 2010 at 06:53

Status:	Needs work	» Needs review
Issue tags:	-Needs tests

File	Size
867928-file-tests-d7.patch	3.12 KB

Extended tests:
- Added check that file downloadable for public scheme
- Added check for changing 'uri_scheme' setting
- Added check for private method download works