Running through an install this weekend of git-HEAD. Found a couple minor bugs with provision:
1) When running a clean install, it assumed that there would be a sites/default/settings.php and failed on a permissions check when it didn't exist. Since drush_make had just grabbed Drupal, there was no such file. Copying default.settings.php to settings.php let it move ahead.
2) Currently provision is generating settings.php files which don't double-quote $_SERVER['db_host'], as they do with the other values like db_user, etc. This causes a php notice level error, and might have other negative consequences.
Comments
Comment #1
omega8cc CreditAttribution: omega8cc commentedRe: 1 - interesting, I can't reproduce it using head. The debug log always says something like "Generated config Drupal settings.php file [38.4 sec, 7.03 MB]". It never expects sites/default/settings.php, it always creates the file using provision template for settings.php.
Re: 2 - yes, it results with some notices during site provisioning, but it doesn't generate any problems, afaik only shows in debug mode something like:
Comment #2
adrian CreditAttribution: adrian commentedi can't confirm the first, but the latter was definitely an issue. I fixed it in head.
Can someone confirm the first part of this ?
Comment #3
adrian CreditAttribution: adrian commented@joshk:
we're still not able to reproduce your first problem. We dont really care about the drupal supplied settings.php, as we rewrite it.
and we also never bootstrap the 'default' site.
Comment #4
adrian CreditAttribution: adrian commentedthink it may have been related to using drush head. that's also been fixed recently.