Running through an install this weekend of git-HEAD. Found a couple minor bugs with provision:

1) When running a clean install, it assumed that there would be a sites/default/settings.php and failed on a permissions check when it didn't exist. Since drush_make had just grabbed Drupal, there was no such file. Copying default.settings.php to settings.php let it move ahead.

2) Currently provision is generating settings.php files which don't double-quote $_SERVER['db_host'], as they do with the other values like db_user, etc. This causes a php notice level error, and might have other negative consequences.

Comments

omega8cc’s picture

Re: 1 - interesting, I can't reproduce it using head. The debug log always says something like "Generated config Drupal settings.php file [38.4 sec, 7.03 MB]". It never expects sites/default/settings.php, it always creates the file using provision template for settings.php.

Re: 2 - yes, it results with some notices during site provisioning, but it doesn't generate any problems, afaik only shows in debug mode something like:

Drush bootstrap phase : _drush_bootstrap_drupal_configuration() [38.41 sec, 7.06 MB]            [bootstrap]
Use of undefined constant v185 - assumed 'v185' settings.php:15 [38.41 sec, 7.06 MB]            [notice]
Use of undefined constant barracuda - assumed 'barracuda' settings.php:15 [38.41 sec, 7.06 MB]  [notice]
Use of undefined constant us - assumed 'us' settings.php:15 [38.41 sec, 7.07 MB]                [notice]
Use of undefined constant host8 - assumed 'host8' settings.php:15 [38.41 sec, 7.07 MB]          [notice]
Use of undefined constant biz - assumed 'biz' settings.php:15 [38.41 sec, 7.07 MB]              [notice]
adrian’s picture

Status: Active » Postponed (maintainer needs more info)

i can't confirm the first, but the latter was definitely an issue. I fixed it in head.

Can someone confirm the first part of this ?

adrian’s picture

@joshk:

we're still not able to reproduce your first problem. We dont really care about the drupal supplied settings.php, as we rewrite it.
and we also never bootstrap the 'default' site.

adrian’s picture

Status: Postponed (maintainer needs more info) » Fixed

think it may have been related to using drush head. that's also been fixed recently.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit e735ee0 on debian, dev-dns, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-simplerinstaller, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by adrian:
    db_host needed to be in quotes. #863882