Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE [#861566]

Comment	File	Size	Author
#8	861566-completely-revert-system-tar-inc.patch	31.65 KB	Stevel

#7	861566-revert-system-tar-inc.patch	30.77 KB	Stevel

	coding_standards_0.patch	31.49 KB	p.brouwers

Comment #1

p.brouwers CreditAttribution: p.brouwers commented 22 July 2010 at 13:24

Status:

Active

» Needs review

Log in or register to post comments

Comment #2

aspilicious CreditAttribution: aspilicious commented 22 July 2010 at 14:05

+++ /var/www/drupal/modules/system/system.tar.inc	2010-07-22 14:53:51.000000000 +0200
@@ -1856,12 +1856,12 @@ class Archive_Tar
+		      && (($v_position = strpos($p_path, ':')) != FALSE)) {

Remove these tabs

40 critical left. Go review some!

Log in or register to post comments

Comment #3

Dries CreditAttribution: Dries commented 22 July 2010 at 23:54

Status:

Needs review

» Fixed

Committed to CVS HEAD. Thanks.

Log in or register to post comments

Comment #4

Damien Tournoud CreditAttribution: Damien Tournoud commented 22 July 2010 at 23:56

Hm.

Do we really want to start hacking our standards into system.tar.inc? This means forking, boys. And forking means maintaining.

Log in or register to post comments

Comment #5

Damien Tournoud CreditAttribution: Damien Tournoud commented 23 July 2010 at 00:43

Status:

Fixed

» Active

I suggest we revert this patch.

Log in or register to post comments

Comment #6

aspilicious CreditAttribution: aspilicious commented 23 July 2010 at 09:39

This patch contained tabs...
Revert?

Log in or register to post comments

Comment #7

Stevel CreditAttribution: Stevel commented 24 July 2010 at 06:27

Status:

Active

» Needs review

File	Size
861566-revert-system-tar-inc.patch	30.77 KB

Here's a plain revert of the changes to system.tar.inc

Log in or register to post comments

Comment #8

Stevel CreditAttribution: Stevel commented 24 July 2010 at 07:32

File	Size
861566-completely-revert-system-tar-inc.patch	31.65 KB

Or should we be going further back? http://drupalcode.org/viewvc/drupal/drupal/modules/system/system.tar.inc

I think none of the changes made are necessary for the correct functioning, so I don't think it's worth forking it for code style (or other) compliance.

Also, a newer version of the Archive_Tar project is available from http://pear.php.net/package/Archive_Tar/. Should we include the newer version, or is the current one just fine?