Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a followup from #690980: Disabled form elements not properly rendered. See http://drupal.org/files/issues/bartik_test.png from that issue. More details to follow
Comment | File | Size | Author |
---|---|---|---|
#17 | drupal-bartik-854432-17.patch | 1002 bytes | tim.plunkett |
#13 | bartik-disabled-form-elements_3.patch | 925 bytes | Jeff Burnz |
#13 | bartik-disabled-form-elements_3.png | 114.08 KB | Jeff Burnz |
#10 | bartik-disabled-form-elements_2.png | 112.5 KB | Jeff Burnz |
#10 | bartik-disabled-form-elements_2.patch | 744 bytes | Jeff Burnz |
Comments
Comment #1
bleen CreditAttribution: bleen commentedIs there an standard to follow here? Just make all the labels light gray? The form elements themselves are generally "styled" by the browser when they are disabled and that appears to be the case in yoroy's screenshot
although some of them (like the select boxes and the file upload in particular) could probably use a bit of love
Comment #2
yoroy CreditAttribution: yoroy commentedyeah, it's about the some of them :) rest is fine.
Comment #3
seutje CreditAttribution: seutje commentedlooks like the single checkbox and radio are darker than their multi counterparts and buttons aren't getting any love either
Comment #4
aspilicious CreditAttribution: aspilicious commentedGo to #690980: Disabled form elements not properly rendered look at the screenshots for garland and seven, and try to mimic their results. Patch for those two is attached in that issue to.
Comment #5
sunsubscribing
Comment #6
Jeff Burnz CreditAttribution: Jeff Burnz commentedAnyone feel like taking this on, trying to clear out these aging issues.
Comment #7
Jeff Burnz CreditAttribution: Jeff Burnz commentedHere's a patch ruthlessly stolen from Seven and adjusted for better contrast levels (the Seven styles fail miserably, sigh...).
You can test with Suns markup test module (zip), you can also grab it from CVS.
Comment #8
sunI don't think we need the extra classes for textarea and select.
Also not sure why you're limiting input to .form-autocomplete and .form-text
We also need a screenshot here.
Powered by Dreditor.
Comment #10
Jeff Burnz CreditAttribution: Jeff Burnz commentedDo we even need to style disabled inputs at all?
Screenshots are there, just not embedded because they are rather long.
I'm having a line ending crisis...
Comment #12
sunI'm not sure how you were able to make that screenshot, but I'd like to know :) The secondary tab "Seven" is active, which normally means that you should see the page/site in Seven theme.
I don't know why form elements have a disabled look in Bartik already, but we should make sure that there are actually styles that force this look. If the look is from the user agent, we need to make sure that's the case for most user agents.
Comment #13
Jeff Burnz CreditAttribution: Jeff Burnz commentedOK, so this should force the styles and I've played a bit with the grays to try and match up with more of the existing grays in Bartik already and genrelly style this a bit better e.g.:
- all borders the same color (#bbb) including the grippie
- toned down the label for a disabled field
- trying to keep all the grays similar warmth, while keeping the contrast levels a low as possible but still pass WCAG AA (4.5:1)
Hopefully these line ending issues I am having today are fixed... sigh...
Screen grab - https://addons.mozilla.org/en-US/firefox/addon/1146/ = awesomeness.
Comment #14
sunLOL. Sorry for not being clear in #12 -- I meant that you should not test this on the local task (tab) "Seven", but instead on the "Bartik" one. I'd like to know how you managed to see the Bartik theme on the Seven tab in that screenshot.... but anyway, different issue. (I guess we should start to think about turning markup_test into an official project...)
Comment #15
Jeff Burnz CreditAttribution: Jeff Burnz commentedOh that, lol, yeah, it didnt make any difference which one I selected, it works when I use stark though (correctly switches to stark).
Comment #16
Jeff Burnz CreditAttribution: Jeff Burnz commented#13: bartik-disabled-form-elements_3.patch queued for re-testing.
Comment #17
tim.plunkettStraight reroll. Great work Jeff!
Comment #18
yoroy CreditAttribution: yoroy commentedTotally worth committing
Comment #19
webchickCommitted to HEAD. Thanks!