Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bleen’s picture

Is there an standard to follow here? Just make all the labels light gray? The form elements themselves are generally "styled" by the browser when they are disabled and that appears to be the case in yoroy's screenshot

although some of them (like the select boxes and the file upload in particular) could probably use a bit of love

yoroy’s picture

yeah, it's about the some of them :) rest is fine.

seutje’s picture

looks like the single checkbox and radio are darker than their multi counterparts and buttons aren't getting any love either

aspilicious’s picture

Go to #690980: Disabled form elements not properly rendered look at the screenshots for garland and seven, and try to mimic their results. Patch for those two is attached in that issue to.

sun’s picture

Jeff Burnz’s picture

Anyone feel like taking this on, trying to clear out these aging issues.

Jeff Burnz’s picture

Status: Active » Needs review
FileSize
112.55 KB
951 bytes

Here's a patch ruthlessly stolen from Seven and adjusted for better contrast levels (the Seven styles fail miserably, sigh...).

You can test with Suns markup test module (zip), you can also grab it from CVS.

sun’s picture

+++ themes/bartik/css/style.css	26 Aug 2010 10:42:58 -0000
@@ -1051,6 +1051,23 @@
+.form-disabled input.form-autocomplete,
+.form-disabled input.form-text,
+.form-disabled textarea.form-textarea,
+.form-disabled select.form-select {

I don't think we need the extra classes for textarea and select.

Also not sure why you're limiting input to .form-autocomplete and .form-text

We also need a screenshot here.

Powered by Dreditor.

Status: Needs review » Needs work

The last submitted patch, bartik-disabled-form-elements.patch, failed testing.

Jeff Burnz’s picture

Status: Needs work » Needs review
FileSize
744 bytes
112.5 KB

Do we even need to style disabled inputs at all?

Screenshots are there, just not embedded because they are rather long.

I'm having a line ending crisis...

Status: Needs review » Needs work

The last submitted patch, bartik-disabled-form-elements_2.patch, failed testing.

sun’s picture

I'm not sure how you were able to make that screenshot, but I'd like to know :) The secondary tab "Seven" is active, which normally means that you should see the page/site in Seven theme.

I don't know why form elements have a disabled look in Bartik already, but we should make sure that there are actually styles that force this look. If the look is from the user agent, we need to make sure that's the case for most user agents.

Jeff Burnz’s picture

Status: Needs work » Needs review
FileSize
114.08 KB
925 bytes

OK, so this should force the styles and I've played a bit with the grays to try and match up with more of the existing grays in Bartik already and genrelly style this a bit better e.g.:

- all borders the same color (#bbb) including the grippie
- toned down the label for a disabled field
- trying to keep all the grays similar warmth, while keeping the contrast levels a low as possible but still pass WCAG AA (4.5:1)

Hopefully these line ending issues I am having today are fixed... sigh...

Screen grab - https://addons.mozilla.org/en-US/firefox/addon/1146/ = awesomeness.

sun’s picture

LOL. Sorry for not being clear in #12 -- I meant that you should not test this on the local task (tab) "Seven", but instead on the "Bartik" one. I'd like to know how you managed to see the Bartik theme on the Seven tab in that screenshot.... but anyway, different issue. (I guess we should start to think about turning markup_test into an official project...)

Jeff Burnz’s picture

Oh that, lol, yeah, it didnt make any difference which one I selected, it works when I use stark though (correctly switches to stark).

Jeff Burnz’s picture

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
1002 bytes

Straight reroll. Great work Jeff!

yoroy’s picture

Totally worth committing

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.