Correct version attached.

CommentFileSizeAuthor
#1 extend_is_broken_beyond_recognition_and_oop_is_not_far_behind.patch1.28 KBchx
extend_is_broken_beyond_recognition.patch718 byteschx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
FileSize
extend_is_broken_beyond_recognition_and_oop_is_not_far_behind.patch1.28 KB

Grrrrr!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

wow, nasty. so, we have broken code, fixed by a broken patch, and the testbot was happy both times. think that's the definition of needing tests.

Crell’s picture

Crell CreditAttribution: Crell commented
Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

The problem is that this code is really hard to test without a completely custom DB driver. I don't think we could manage that easily.

That said, this is definitely a bug. In fact I remember fixing it a year ago, so I don't know why it's still here. Oh well. #1 is the correct fix, and looks RTBC to me.

It's not critical, though, as none of the core-supported DB drivers break from this.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Code comments would have helped to at least explain the WTF to some extent. Just reading the patch... still WTF. "Glad it works for you."

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Basically, the old version was checking for the following classnames:

mysql
SelectQueryExtender

instead of:

SelectQueryExtender_mysql
SelectQueryExtender

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.