I think, as a result of #715142: [beta blocker blocker] Various URLs escaped twice, since check_url() resp. filter_xss_bad_protocol() calls check_plain(), theme_more_link() now uses l(). All the usages of theme('more_link', ...) already call url() for the url argument. This causes the links generated to include the base-path twice ie http://localhost/drupal-cvs//drupal-cvs/admin/content
Should the url argument be changed to path, and all the theme('more_link, ...) calls be updated to suit and remove their url() calls? (small API change)
Or is there another option, ie rollback the theme_more_link change
current theme.inc code:
function theme_more_link($variables) {
return '<div class="more-link">' . l(t('More'), $variables['url'], array('attributes' => array('title' => $variables['title']))) . '</div>';
}
Comment | File | Size | Author |
---|---|---|---|
#6 | 850178-feed_icon-url-d7.patch | 4.43 KB | andypost |
#4 | 850178.001.patch | 9.22 KB | karschsp |
#3 | 850178.000.patch | 5.11 KB | karschsp |
Comments
Comment #1
asimmonds CreditAttribution: asimmonds commentedand theme_more_help_link() is affected as well (only one usage left in core, in forum.module, which is BTW intentional #728644: No link to Help pages from configuration pages )
Comment #2
karschsp CreditAttribution: karschsp commentedI ran across this today as well. Enabled aggregator module, added a feed, enabled the aggregator block, and the more link points to 'http://aggregator/sources/1'
Luckily, there's only 3 places in core where theme('more_link') is called.
I will try to provide a patch later today.
Comment #3
karschsp CreditAttribution: karschsp commentedHere's a patch. Basically I just removed url() from the handful of items that call theme_more_link
Comment #4
karschsp CreditAttribution: karschsp commentedTurns out this issue also affects theme_feed_icon as well, so here's an updated patch.
Comment #5
andypostCould we incorporate this change with #866220-9: URL parameter for theme_more_link() should not pass url()
Comment #6
andypostRe-roll without changes from #866220: URL parameter for theme_more_link() should not pass url()
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.