I think, as a result of #715142: [beta blocker blocker] Various URLs escaped twice, since check_url() resp. filter_xss_bad_protocol() calls check_plain(), theme_more_link() now uses l(). All the usages of theme('more_link', ...) already call url() for the url argument. This causes the links generated to include the base-path twice ie http://localhost/drupal-cvs//drupal-cvs/admin/content

Should the url argument be changed to path, and all the theme('more_link, ...) calls be updated to suit and remove their url() calls? (small API change)
Or is there another option, ie rollback the theme_more_link change

current theme.inc code:

function theme_more_link($variables) {
  return '<div class="more-link">' . l(t('More'), $variables['url'], array('attributes' => array('title' => $variables['title']))) . '</div>';
}
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

asimmonds’s picture

and theme_more_help_link() is affected as well (only one usage left in core, in forum.module, which is BTW intentional #728644: No link to Help pages from configuration pages )

karschsp’s picture

I ran across this today as well. Enabled aggregator module, added a feed, enabled the aggregator block, and the more link points to 'http://aggregator/sources/1'

Luckily, there's only 3 places in core where theme('more_link') is called.

I will try to provide a patch later today.

karschsp’s picture

Status: Active » Needs review
FileSize
5.11 KB

Here's a patch. Basically I just removed url() from the handful of items that call theme_more_link

karschsp’s picture

FileSize
9.22 KB

Turns out this issue also affects theme_feed_icon as well, so here's an updated patch.

andypost’s picture

andypost’s picture

Title: Url argument to theme_more_link() has url() applied twice » Url argument to drupal_feed_icon() and theme_feed_icon() has url() applied twice
Status: Needs review » Reviewed & tested by the community
FileSize
4.43 KB
Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.