Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is no test for updating poll content, but it looks like it is needed as pointed out in #817216: poll_update_7001 does not work.
Comment | File | Size | Author |
---|---|---|---|
#24 | 848368-poll-new-generation-script.patch | 615.25 KB | Stevel |
#19 | 848368-poll-upgrade-path.patch | 609.41 KB | Damien Tournoud |
#14 | 848368-load-new-modules.patch | 608.37 KB | Stevel |
#9 | 848368-poll-test-4.patch | 608.21 KB | Stevel |
#7 | 848368-poll-test-3.patch | 608.24 KB | Stevel |
Comments
Comment #1
Stevel CreditAttribution: Stevel commentedAnd here's an initial patch. I'm sure it will fail, but sadly that's because of genuine bugs in the upgrade path.
Comment #3
Stevel CreditAttribution: Stevel commentedSummary of the currently failing tests:
The first exception (undefined variable field) is being resolved at #706842: Improve comments for the taxonomy upgrade path. The last two failures are caused by the preceding FieldException.
The field_create_instance function is probably called from node_update_7006 indirectly, so all other exceptions seem related; Looking into that.
Comment #4
Stevel CreditAttribution: Stevel commentedUpdated version of the tests. Using drupal_install_modules doesn't rebuild {node_types} causing various warnings and errors noted above. New solution is to enable the modules manually before running the content generation script.
Another strange issue is that the test only works when the poll.module is actually enabled on the site running the test. Otherwise (for a reason unknown to me) the "Results" tab isn't displayed on poll nodes, only "View" and "Edit".
Expecting one failure now ("undefined variable: field").
Comment #6
Stevel CreditAttribution: Stevel commentedThere are more tests failing. Strange thing is, it doesn't happen when poll.module is enabled on the site running the tests.
First debugging yields the following results:
- module_list includes poll.module
- module_implements('menu') doesn't return poll.module, causing the poll menu items not being included in {menu_router}.
Further investigation needs to point out why this happens.
Comment #7
Stevel CreditAttribution: Stevel commentedLets see what this gives on the testbot...
Major thanks to chx for helping and guiding me to find why these apparently strange things were happening.
Comment #9
Stevel CreditAttribution: Stevel commentedLeave module_list(TRUE) in performUpgrade, so the tests know about newly enabled/disabled modules.
Comment #11
Stevel CreditAttribution: Stevel commented#7: 848368-poll-test-3.patch queued for re-testing.
Comment #12
Stevel CreditAttribution: Stevel commented#9: 848368-poll-test-4.patch queued for re-testing.
Comment #14
Stevel CreditAttribution: Stevel commentedAnother try, now we explicitly load modules that are enabled in the test database, but not on the testing client.
Comment #15
Stevel CreditAttribution: Stevel commentedNeeds review again
Comment #17
Damien Tournoud CreditAttribution: Damien Tournoud commentedWoo, great job. Now let's just merge this one with my patch for taxonomy_update_7005() and call it a go.
Comment #18
Stevel CreditAttribution: Stevel commented#14: 848368-load-new-modules.patch queued for re-testing.
Not there yet. Testbot complains about an error in locale.test now, but not sure how that can be related...
Comment #19
Damien Tournoud CreditAttribution: Damien Tournoud commentedActually, for the sake of isolating test runs, I suggest we do something like that.
Comment #20
Stevel CreditAttribution: Stevel commentedRTBC based on #17 and my review of Damien's modifications
Comment #21
Stevel CreditAttribution: Stevel commentedThis patch makes some changes to the upgrade testing framework as well as add a more generic testing database, both of which are needed for #706842: Improve comments for the taxonomy upgrade path, so marking it accordingly.
Comment #22
int CreditAttribution: int commentedComment #23
philbar CreditAttribution: philbar commentedThis module does not appear on the D7 beta blocker section of the community initiative page. Should it be?
Comment #24
Stevel CreditAttribution: Stevel commentedMade some corrections to the generation script, which now also enables needed modules and runs cron after installing modules (but before adding the content).
Modifies the dump script to include a header containing the loaded modules as well.
Comment #25
chx CreditAttribution: chx commentedVery nice work. Given that the generation script was patch ping-pong between Stevel and me of course I like it :p but then this is an absolute first someone wrote a poll generation script, even devel generate does not do that. Stevel is awesome.
Comment #26
Dries CreditAttribution: Dries commentedVery cool. It does increase the size of Drupal by 0.6MB though -- are we cool with doing that?
Comment #27
chx CreditAttribution: chx commentedYes we have discussed this -- we can change the packaging script to make the default tarball exclude this directory completely and have another with this. Also in a followup patch we can experiment with gzipping it down to almost nothign but for now we want to see diffs.
Comment #28
webchickFor reference, the place this was discussed was #706842-22: Improve comments for the taxonomy upgrade path and below, a sister issue to this one.
Comment #29
chx CreditAttribution: chx commentedSo what happened to this issue this week?
Comment #30
chx CreditAttribution: chx commentedAnyone around?
Comment #31
Dries CreditAttribution: Dries commentedNothing happened with this patch last week (that is OK) but I committed it just now after another review. Thanks to Stevel and Damien Tournoud for driving this home.
Comment #32
chx CreditAttribution: chx commentedIssues like this cause me to slip down the contributor top list. :( oh well.
Comment #33
webchickSorry; this patch has been on my "to review and commit list" since July 16, but real life has not been so kind to my patch committing schedule. Thanks, Dries, for picking it up!
Mmmm. I love the smell of fresh beta, and this patch gets us a huge chunk of the way there.