Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Along the same lines as #764726: hook_taxonomy_term_presave() is missing
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal-835046-taxonomy_vocabulary_presave-D7.patch | 1.68 KB | mikeytown2 |
drupal-taxonomy_vocabulary_presave-D7.patch | 1.62 KB | mikeytown2 | |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedforgot to rename the function
Its the only hook missing
http://api.drupal.org/api/search/7/hook_taxonomy_
Comment #2
bleen CreditAttribution: bleen commentedSeems really straightforward ... I just took a quick test drive and everything seems in order.
One more review for good luck and we can probably mark this RTBC
Comment #3
marcingy CreditAttribution: marcingy commentedLooks good.
Comment #4
webchickI want to be really careful here with making API changes this late in the game (even if they are "harmless" additions), because it sends the totally wrong signal about API freeze, and we need to be focused on releasing Drupal 7, not adding more shiny.
On the other hand, looking at http://api.drupal.org/api/search/7/hook_taxonomy_ it definitely seems clear that this is a simple API omission, rather than a "new" feature. Additionally, since terms are entities, the lack of a presave hook for terms was in fact a bug with the conformance to the entity interface, and since vocabularies are also entities, this qualifies here as well.
Committed to HEAD. But please watch it with that "critical" status and only use it for issues that are actually critical and cause Drupal to cease to function.
Also, since this is an API change, it needs to be documented on the Module update page.
Comment #5
webchickComment #6
mikeytown2 CreditAttribution: mikeytown2 commentedAdded documentation
http://drupal.org/node/224333
http://drupal.org/node/224333/revisions/view/1040446/1054304
Mark as fixed if this is good enough.
Comment #7
catchI think that's fine.