For our site frontends (webforms, views exposed filters, etc), this is an extremely useful module! However, it doesn't work right with many backend functions (views UI, cck multigroup on node edit forms, and module filter thus far). I figure there are three ways to attack this: First, the module could have options (similar to blocks) for which pages to affect. Second, the module could partner with "context" module to select pages to affect. Third, the module could provide options for which active themes to affect, then only act on pages loading selected theme(s). The third option would work well with "admin menu" module, but the second option would be more flexible and very cool.

CommentFileSizeAuthor
#5 uniform-825036.patch5.92 KBrealityloop

Comments

realityloop’s picture

realityloop commented

I will look into adding this soon.

geerlingguy’s picture

geerlingguy commented

I'm also having problems with Lightbox 2 when running this module... just fyi—I don't know if it's just certain pages or the whole site (might be because of jQuery update, though).

[Edit: RE: Below... will do! #831062: Module breaks Lightbox JS?]

realityloop’s picture

realityloop commented

@gerlingguy please post as a separate issue.

nicholas.alipaz’s picture

nicholas.alipaz commented

Just thought I would add my two cents. The option to enable it on a per theme basis may be difficult. I had issues getting it to work on a similar module I made for myself. The code I had was along the lines of:

function stitch_jqplugins_init() {
  /* only load this stuff up if we are using the appropriate theme */
  init_theme();
  global $theme_key;
  $themes = list_themes(); // get all themes
  $theme_object = $themes[$theme_key]; // find the object for the theme the user is using
  $theme_name_space =  $theme_object->name;
  if ($theme_name_space == 'stitch') {
    drupal_add_library('jqtransform', '1.1', array($type => 'theme'));

  }
}

It worked but it caused the block edit page to load the wrong theme, so I did away with it. It was the use of init_theme(); that was causing the issue. The alternative solution I decided to use was to simply rename my function to function stitch_jqplugins_initialize() and call it from my theme's template.php. Then I just removed the theme detection from the function.

That being said, another possibility would be to simply require users to add the call to the function in their template.php but I admit that is not optimal. If anyone else knows of better theme detection code I would be interested.

The option for enabling on specific pages certainly works, but not the most optimal solution for sure.

This module already requires two other modules, so I don't think I would like it to require context since not everyone uses it. I like context, but I don't think it is warranted here. Maybe it should be made to "integrate with context" when context is enabled on a site.

realityloop’s picture

realityloop commented
Status: Active » Needs review
StatusFileSize
new uniform-825036.patch5.92 KB

There is now an option to disable within the admin section of the site.

note: jquery.uniform now requires jquery 1.4.2, please read updated readme.

realityloop’s picture

realityloop commented

Option to disable in admin and on edit/add forms in 6.x-1.1

realityloop’s picture

realityloop commented
Status: Needs review » Fixed

Forgot to change status

Option to disable in admin and on edit/add forms in 6.x-1.1

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

marcus178’s picture

marcus178 commented

I'm trying to disable for when I'm editing or adding content. I can see the option to disable in admin but not for this.

realityloop’s picture

realityloop commented

re-added as a separate option