The new status checks are broken with MySQLi.

warning: mysqli_get_server_info() expects parameter 1 to be mysqli, null given in /Users/ted/Documents/webdata/drupalCVS/includes/database.mysqli.inc on line 24.

If I switch to the "mysql" interface it works great, it detects my 5.0.19, otherwise, I get the warning above and the MySQL version is empty.

CommentFileSizeAuthor
#7 drupal_mysqli_cvs20060903.diff.txt1.11 KBzoeloelip
#3 mysqli_status_report.patch_0.txt1.14 KBdavemicc
#2 mysqli_status_report.patch.txt1.14 KBdavemicc
#1 mysqli_1.patch533 bytesm3avrck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Active » Needs review
FileSize
mysqli_1.patch533 bytes

Here's a patch which fixes this. There was not $connection to lookup. Note, we don't have to pass a valid $url to connect to the database to get the version information, an empty string works.

davemicc’s picture

davemicc CreditAttribution: davemicc commented
FileSize
mysqli_status_report.patch.txt1.14 KB

That patch causes Drupal to give me an "Unable to connect to database server" access denied error. This patch passes the global $active_db connection object to mysqli_get_server_info() which seems to be consistent with what the other functions in the file do.

davemicc’s picture

davemicc CreditAttribution: davemicc commented
FileSize
mysqli_status_report.patch_0.txt1.14 KB

Oops... I forgot to configure my editor to use spaces instead of tabs.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented

Hmm strange, yeah I should have used the global $db_active.

Nice work Dave, better patch!

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

confirmed fixed

calebgilbert’s picture

calebgilbert CreditAttribution: calebgilbert commented

Can confirm that this patched worked for me too. Thanx.

zoeloelip’s picture

zoeloelip CreditAttribution: zoeloelip commented
FileSize
drupal_mysqli_cvs20060903.diff.txt1.11 KB

Any reason why mysqli_get_server_info is called twice? Why not use $info from the first call?

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)