default user timezone to site timezone, not to GMT [#8154]

The system module should default the user timezone to the site timzone, not to GMT.

I fixed this as follows. Not that I also fixed "appropriate" vs. "appropriately".

diff -r1.138 system.module
98c98,100
< $data[t('Locale settings')] = form_select(t("Time zone"), "timezone", $edit["timezone"], $zones, t("Select what time you currently have and your time zone settings will be set appropriate."));
---
> // set the default to be the same as the site default
> $seltz = $edit["timezone"] ? $edit["timezone"] : variable_get('date_default_timezone', 0);
> $data[t('Locale settings')] = form_select(t("Time zone"), "timezone", $seltz, $zones, t("Select what time you currently have and your time zone settings will be set appropriately."));

Comment	File	Size	Author
#6	default_user_timezone-20040803.patch	1.02 KB	TDobes
#6
#3	default_user_timezone.patch	1.07 KB	TDobes
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mda-1 CreditAttribution: mda-1 commented 30 May 2004 at 21:31

I was the submitter of this bug. I guess there is no way to take ownership of an anonymous post after it has been submitted.

Comment #2

Dries CreditAttribution: Dries commented 7 July 2004 at 22:54

Care to attach a patch? Also, when you add a patch, set the status to 'patch' so it ends up in the patch queue.

Comment #3

TDobes CreditAttribution: TDobes commented 13 July 2004 at 08:36

Assigned:

Unassigned

» TDobes

File	Size
default_user_timezone.patch	1.07 KB

Patch is now attached and in appropriate format.

Comment #4

jhriggs CreditAttribution: jhriggs commented 13 July 2004 at 12:12

+1. (I have modified my sites similarly.) The help text/description is awful, though. It doesn't really say anything meaningful. Can we rewrite it? Perhaps something along the lines of "Select your current time zone. Dates and times throughout this site will be displayed using this time zone."

Comment #5

Steven CreditAttribution: Steven commented 22 July 2004 at 04:52

I think the patch needs to have isset($edit['timezone']) rather than just $edit['timezone'] in the conditional. If a site's timezone is set to non-GMT, and a user sets it to GMT, then his/her zone would keep getting reset when he went to the account configuration.