Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It's highly annoying that there are colours specified inside admin.css.
I can live with text-sizes, padding/margins, and all other things we would like to put it in by default, but not this..
Simple and straight forward patch. 1 review should be enough to set this RTBC..
Comment | File | Size | Author |
---|---|---|---|
#5 | admin_7.patch | 2.73 KB | m3avrck |
color-removal-admin-css.diff | 1.68 KB | Stefan Nagtegaal | |
Comments
Comment #1
m3avrck CreditAttribution: m3avrck commentedThis went in yesterday in a more robust fashion: http://drupal.org/node/80717
Comment #2
m3avrck CreditAttribution: m3avrck commentedOops, was thinking of the other colors, looks like a few were missed.
If you're going to remove colors from admin.css, then you need to update all of the themes drupal ships with some default colors.
Comment #3
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedI did not put extra definition inside our themes, because I think the pages look cleaner without extra styling.
Besides that, maybe we can get rid of all the themes we currently have in core and finally put some new (decent) themes in it?
Comment #4
eaton CreditAttribution: eaton commentedA big -1 to that. I'm in favor of moving the definitions to the themes, but taking them out entirely is not a 'bug fix' -- it's a debate about aesthetics.
That has nothing to do with CSS being in the theme vs. the defaults. :)
Comment #5
m3avrck CreditAttribution: m3avrck commentedHere's a better patch. This moves those hardcoded colors into theme specific styles, this follows the last admin css patch that went in. admin.css should be fully santized now :-)
Comment #6
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedWorks as expected, and is indeed a somewhat better approach..
Setting RTBC..
(This does not say, I don't think we need new themes in core)
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #8
(not verified) CreditAttribution: commented