drupal_maintenance_theme() has dependency on filter.module which isn't included [#80849]

if install_already_done_error() gets called it triggers a call to drupal_maintenance_theme() with a minimal bootstrap that doesn't include filter.module. This results in a Call to undefined function filter_xss_bad_protocol() in common.inc::check_url(). The solution proposed is to include filter.module in drupal_maintenance_theme(), though a different solution might exist.

Comment	File	Size	Author
	bootstrap.inc_10.patch	700 bytes	robertDouglass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

robertDouglass CreditAttribution: robertDouglass commented 26 August 2006 at 19:02

The problem is more widespread. drupal_not_found() triggers a missing dependency on block.module. In fact, loading common.inc without a bunch of modules seems dangerous. I think we should at least load the required modules anytime we load common.inc. Am I right that these bugs are a result of Moshe's patch for 404 handling?

Comment #2

drumm

he/him

NY, US

CreditAttribution: drumm commented 30 August 2006 at 08:03

Status:

Needs review

» Fixed

Committed to HEAD.

Comment #3

robertDouglass CreditAttribution: robertDouglass commented 30 August 2006 at 12:23

Drumm... any thoughts about the other dependency problems? Is including the individual files like in my patch a robust answer? Or should we have a drupal_load_required_modules() function that addresses all at once?