Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In the user interface string, there are some sentences like the following, which seem run-on sentences to me:
Error, this type of connection protocol (%backend) does not exist.
It would be probably better to use
Error: this type of connection protocol (%backend) does not exist.
Comments
Comment #1
apadernoComment #2
apadernoThis is the patch I can provide; I didn't find any other similar sentences.
Comment #3
apadernoMaybe the file name is not correct. :-)
Comment #4
apadernoComment #5
apadernoLet's try again: the status should be
. :-)Comment #6
Dries CreditAttribution: Dries commentedWe usually don't add 'Error:' to the message of an exception. Maybe it should simple be something like:
"Non-supported connection protocol (%backend)."
I have not looked at the surrounding code so 'non-supported' might not be the proper word.
Comment #7
apadernoI re-rolled the patch, and removed
. As it's an exception, it's supposed to report an error, not a warning.Comment #9
apadernoClearly, it doesn't apply as HEAD has been changed.
I changed the error message, and made it shorter.
Comment #10
apadernoIt was reported me that I was using a not correct term (thanks Imani!). I am fixing the title.
Comment #11
apaderno#9: 806992_uncorrect_punctuation_updated.patch queued for re-testing.
Comment #12
yoroy CreditAttribution: yoroy commentedBye CVS, hello Git. Removing the "Error," bits is still worthwhile.
Comment #13
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedRecreating the previously submitted patch for as a git patch.
Comment #14
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedOops. Re-submitting the patch with the right status.
Comment #16
yoroy CreditAttribution: yoroy commentedrocket.nova Thanks for the reroll. Maybe http://drupal.org/node/1054616 can help in making the patch in -p1 format. I'm a Git noob myself, so can only point to a possible solution :) Thanks again!
Comment #17
rfay@rocket.nova you could have just set the issue to "Needs Review" and it would have caused the patch to test. I'm a bit baffled why #13 applied and #14 didn't :-) Setting to "Needs review" again.
Comment #18
rfay#14: correct_authorize_runon_sentence-806992-14.patch queued for re-testing.
Comment #20
drupal_was_my_past CreditAttribution: drupal_was_my_past commented@rfay I failed to realize that just changing the status in the next comment would queue my patch in #13 for testing. Thanks for the confirmation! Also, #14 was a bad patch. It was a diff in the wrong direction. :(
Here is an updated patch ready for testing.
Comment #21
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedRe-rolled after #22336: Move all core Drupal files under a /core folder to improve usability and upgrades core directory structure for Drupal 8 was changed.
Comment #22
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedComment #23
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedRe-rolled to update to current code.
Comment #24
apadernoI think it is good to go.
Comment #25
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #26.0
apadernoFixed grammar.