In the user interface string, there are some sentences like the following, which seem run-on sentences to me:

Error, this type of connection protocol (%backend) does not exist.

It would be probably better to use

Error: this type of connection protocol (%backend) does not exist.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

apaderno’s picture

Component: other » user interface text
apaderno’s picture

FileSize
855 bytes

This is the patch I can provide; I didn't find any other similar sentences.

apaderno’s picture

Maybe the file name is not correct. :-)

apaderno’s picture

Priority: Minor » Normal
apaderno’s picture

Status: Active » Needs review

Let's try again: the status should be needs review. :-)

Dries’s picture

We usually don't add 'Error:' to the message of an exception. Maybe it should simple be something like:

"Non-supported connection protocol (%backend)."

I have not looked at the surrounding code so 'non-supported' might not be the proper word.

apaderno’s picture

I re-rolled the patch, and removed Error: . As it's an exception, it's supposed to report an error, not a warning.

Status: Needs review » Needs work

The last submitted patch, 806992_uncorrect_punctuation_2nd_try.patch, failed testing.

apaderno’s picture

Status: Needs work » Needs review
FileSize
837 bytes

Clearly, it doesn't apply as HEAD has been changed.
I changed the error message, and made it shorter.

apaderno’s picture

Title: Running sentences? » Run-on sentence?

It was reported me that I was using a not correct term (thanks Imani!). I am fixing the title.

apaderno’s picture

yoroy’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work

Bye CVS, hello Git. Removing the "Error," bits is still worthwhile.

drupal_was_my_past’s picture

Title: Run-on sentence? » Run-on sentence in authorize.inc
FileSize
692 bytes

Recreating the previously submitted patch for as a git patch.

drupal_was_my_past’s picture

Status: Needs work » Needs review
FileSize
692 bytes

Oops. Re-submitting the patch with the right status.

Status: Needs review » Needs work

The last submitted patch, correct_authorize_runon_sentence-806992-14.patch, failed testing.

yoroy’s picture

rocket.nova Thanks for the reroll. Maybe http://drupal.org/node/1054616 can help in making the patch in -p1 format. I'm a Git noob myself, so can only point to a possible solution :) Thanks again!

rfay’s picture

Status: Needs work » Needs review

@rocket.nova you could have just set the issue to "Needs Review" and it would have caused the patch to test. I'm a bit baffled why #13 applied and #14 didn't :-) Setting to "Needs review" again.

rfay’s picture

Status: Needs review » Needs work

The last submitted patch, correct_authorize_runon_sentence-806992-14.patch, failed testing.

drupal_was_my_past’s picture

Status: Needs work » Needs review
FileSize
692 bytes

@rfay I failed to realize that just changing the status in the next comment would queue my patch in #13 for testing. Thanks for the confirmation! Also, #14 was a bad patch. It was a diff in the wrong direction. :(

Here is an updated patch ready for testing.

drupal_was_my_past’s picture

drupal_was_my_past’s picture

Assigned: Unassigned » drupal_was_my_past
drupal_was_my_past’s picture

Priority: Normal » Minor
FileSize
712 bytes

Re-rolled to update to current code.

apaderno’s picture

Status: Needs review » Reviewed & tested by the community

I think it is good to go.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

apaderno’s picture

Issue summary: View changes

Fixed grammar.