The attached patch removes some of the E_NOTICE messages that appear especially during the installation of Drupal. Note that this patch does not remove all of them.

CommentFileSizeAuthor
#6 common.inc_44.patch1.07 KBlyricnz
#5 phptemplate.engine_17.patch761 byteslyricnz
#4 system.module_34.patch1.22 KBlyricnz
#3 common.inc_43.patch1.07 KBlyricnz
#2 module.inc_1.patch766 byteslyricnz
notice.patch3.85 KBkkaefer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Needs work

Partially committed to HEAD.

I'm concerned about the form.inc changes having unintended side effects. Please look over and explain why the changes are correct.

In the future, please post patches to remove notices to at least one separate issue for each file changed to allow space for review.

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
FileSize
module.inc_1.patch766 bytes

Patch warning about Undefined index in includes/module.inc.

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
FileSize
common.inc_43.patch1.07 KB

Patch warnings about Undefined index in includes/common.inc

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
FileSize
system.module_34.patch1.22 KB

Patch warnings about Undefined index in modules/system/system.module

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
FileSize
phptemplate.engine_17.patch761 bytes

Patch warnings about Undefined index in themes/engines/phptemplate/phptemplate.engine

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
Title: Fix some of the E_NOTICE messages » Previous patch was broken - includes/common.inc
FileSize
common.inc_44.patch1.07 KB

Updated patch for includes/common.inc

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented
Title: Previous patch was broken - includes/common.inc » Fix some of the E_NOTICE messages

Per advice in #drupal, I'm going to resubmit these patches as individual issues. I guess you can ignore them here.

kkaefer’s picture

kkaefer CreditAttribution: kkaefer commented
Status: Needs work » Closed (fixed)