Active
Project:
Bad judgement
Version:
7.x-1.0-rc38
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Apr 2010 at 12:18 UTC
Updated:
18 Mar 2015 at 20:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
johnalbinLOL!
You're right! Of course, you would have to enable this module in order to get the dependency inserted via that hook.
Comment #2
catchDetails, details.
edit: OMG patch size!
Comment #3
mbutcher commentedThis is the greatest patch I have ever seen in my entire life.
In the true spirit of this module, I'm marking it reviewed and tested even though I neither reviewed it nor tested it.
Comment #4
dave reid+1lolz
Comment #5
seutje commentedthis is no coincidence, greater powers are at work here
Comment #6
SeanBannister commentedLMAO, awesome!
Comment #7
greggles+1. will buy again. A truly positive addition to the module space.
Comment #8
Nick Lewis commentedGuys I dunno. What about the themers?
Comment #9
moshe weitzman commentedNice.
If you like this sort of humor, join us at Drupal for Evil
Comment #10
Nick Lewis commentedDon't trump me Moshe.
Comment #11
Nick Lewis commentedredintegro est recipero
Comment #12
Nick Lewis commented...
Comment #13
Nick Lewis commentedThere's known workaround where module developers can directly edit the module to make this work. Good work team.
Comment #14
johnalbinNow that the consensus is to not commit this, I've committed it.
http://drupal.org/commitlog/commit/14044/ed4c6ecd16876af0b6524225e27a381...
Comment #15
Nick Lewis commentedI believe we need a feature that rebuilds theme cache on every page load. I'm putting it in this issue since this is where the discussion is happening.
Comment #16
gregglesCAUTION, CAUTION.
IRONY ALERT: there are at least two projects that do that already.
Comment #17
dmitrig01 commentedNick, I really think we need it rebuilt *twice* each page load - what if I make some changes while the page is loading? I don't want those not to propagate through...
Comment #18
mbutcher commented+1
Oh, and I have something else to say. The name of this module should be changed to something else. I don't know what though.
Comment #19
deekayen commentedHere's some stuff you can add to your drush make file:
Example stub:
Comment #20
deekayen commentedI just learned core patches in drush make are regular diffs, not git ones.
Comment #21
robloachPHP module no longer exists in Drupal 8. You're welcome.
Discussion about having it use Bad Judgement: #2089647: Improve documentation about PHP security implication
Comment #22
greg.1.anderson commentedc.f. #2106561: Missing dependency on bad judgement
Comment #23
laboratory.mike#15:
Fixing here: #2455085: No Hooks?
Because adding hooks totally has to do with theming. And this thread.