drupal_get_destination() should return URL in 'source' format, not in 'alias' format [#78377]

Subject says almost all. The result of the function is set as 'destination' parameter for the target url of forms. If the form is submitted and form input has been processed, Drupal will drupal_goto() to the 'destination' URL. Because drupal_goto() translates the URL to alias form, the URL passed to drupal_goto should be in source form.

At least, that's what I think ;-) I definitely don't know many intimate details of Drupal's inner functioning, so I could be wrong. I've posted my solution in http://drupal.org/node/78356

Comment	File	Size	Author
#5	common.inc.patch_4.txt	631 bytes	eveltman

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drumm

he/him

NY, US

CreditAttribution: drumm commented 15 August 2006 at 07:35

Status:

Needs review

» Active

There isn't a patch file attached here.

Comment #2

eveltman CreditAttribution: eveltman commented 15 August 2006 at 19:44

Sorry for not making a patch file, I'm not too familiar with that tool and didn't have the time to make myself familiar with it. But I placed the fixed code on http://drupal.org/node/78356. That's why I thought 'patch (code needs review)' was an appropriate status for the issue.

Comment #3

eveltman CreditAttribution: eveltman commented 30 August 2006 at 19:02

Status:

Active

» Needs review

Changing status back to 'patch' again. See link in the original description. The fixed function is there.

Comment #4

StevenPatz

he/him

English

Alexandria VA

CreditAttribution: StevenPatz commented 30 August 2006 at 19:29

Status:

Needs review

» Active

There is no patch to review.

Comment #5

eveltman CreditAttribution: eveltman commented 19 November 2006 at 15:26

Version:	4.7.3	» 4.7.4
Status:	Active	» Needs review

File	Size
common.inc.patch_4.txt	631 bytes

OK, I ran into it again with 4.7.4. Now I had a little more time, so I created a real patch file. Hope it's OK now.

Comment #6

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 11 December 2006 at 17:27

Version:

4.7.4

» 5.x-dev

moving

Comment #7

Steven CreditAttribution: Steven commented 12 December 2006 at 06:12

Status:

Needs review

» Patch (to be ported)

This patch does expose a non-clean URL, but as its only used for form submission, it's acceptable. Internally, we should never use aliases in drupal_goto() calls.

Tested and committed to HEAD.