Politically charged example in system.api.php [#778950]

JAPerry found this during the code sprint. In system.api.php there is an example with the following code:

// Quebec has seceded from Canada. Add to country list.
$countries['QC'] = 'Quebec'

This is a politically charged issue, and should not be used in jest. There were people kidnapped and killed because of this (read about the October Crisis.

The attached patch replaces this with a fictional country (Elbonia from the Dilbert cartoon strip).

Comment	File	Size	Author
#6	country-alterV3.patch	663 bytes	jhodgdon
#6
#5	country-alterV2.patch	660 bytes	aspilicious
#5
	country-alter.patch	667 bytes	kbahey

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 22 April 2010 at 20:07

Status:

Needs review

» Reviewed & tested by the community

Ok, let's do that.

Comment #2

22 April 2010 at 20:20

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, country-alter.patch, failed testing.

Comment #3

Scott Reynolds CreditAttribution: Scott Reynolds commented 22 April 2010 at 20:30

Status:

Needs work

» Needs review

country-alter.patch queued for re-testing.

Comment #4

23 April 2010 at 05:10

Status:

Needs review

» Needs work

The last submitted patch, country-alter.patch, failed testing.

File	Size
country-alterV2.patch	660 bytes

Comment #6

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 23 April 2010 at 16:40

Status:

Needs review

» Reviewed & tested by the community

File	Size
country-alterV3.patch	663 bytes

It would be better to use the (correct) punctuation from the original. In English, it is not correct to splice two sentences together with a comma between them, unless you use a conjunction like "so" or "and" or "but".

Here's a revised patch with a conjunction. Good idea folks!