Yeah, I didn't ever expect to write a performance patch for color.module either.

A theme's color.inc file will be loaded and parsed 4 different times. This is wasteful. It would also conflict with, for example, putting a drupal_add_js() into a color.inc file. (Part of the plan for #762474: Get Color Module Preview to work.)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Merrill’s picture

The patch.

Steven Merrill’s picture

Now sans spacing issues.

timcosgrove’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies correctly; static variable works as expected (stepped through).

Steven Merrill’s picture

@webchick I just verified that the error message that you saw during my demo of Bartik's preview has nothing to do with this patch.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.