Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Yeah, I didn't ever expect to write a performance patch for color.module either.
A theme's color.inc file will be loaded and parsed 4 different times. This is wasteful. It would also conflict with, for example, putting a drupal_add_js() into a color.inc file. (Part of the plan for #762474: Get Color Module Preview to work.)
Comment | File | Size | Author |
---|---|---|---|
#2 | 778880-smerrill-color-module-static-2.patch | 618 bytes | Steven Merrill |
#1 | 778880-smerrill-color-module-static.patch | 622 bytes | Steven Merrill |
Comments
Comment #1
Steven Merrill CreditAttribution: Steven Merrill commentedThe patch.
Comment #2
Steven Merrill CreditAttribution: Steven Merrill commentedNow sans spacing issues.
Comment #3
timcosgrove CreditAttribution: timcosgrove commentedPatch applies correctly; static variable works as expected (stepped through).
Comment #4
Steven Merrill CreditAttribution: Steven Merrill commented@webchick I just verified that the error message that you saw during my demo of Bartik's preview has nothing to do with this patch.
Comment #5
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.