modules/file/file.js has a few coding standards problems. (Reference: http://drupal.org/node/172169). In particular, there should always be a space between the special word "function" and the parentheses that follow. Example:

Bad: var foo = function() {

Good: var foo = function () {

This file requires cleanup to comply with Drupal's coding standards. This is a good issue for someone's first patch.

CommentFileSizeAuthor
#2 777064.patch4.31 KBspyderboy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

spyderboy’s picture

spyderboy CreditAttribution: spyderboy commented
Assigned: Unassigned » spyderboy
spyderboy’s picture

spyderboy CreditAttribution: spyderboy commented
FileSize
777064.patch4.31 KB
cwgordon7’s picture

cwgordon7 CreditAttribution: cwgordon7 commented
Status: Active » Needs review
markabur’s picture

markabur CreditAttribution: markabur commented
Status: Needs review » Reviewed & tested by the community

Looks good, all occurrences of "function()" in the file have been replaced with "function ()".

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

just a note, is their a style doc about this?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice clean-up! :)

Committed to HEAD.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Strange mix of unattach and detach... What is unattach? it's not documented!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Not sure, but let's discuss in a separate issue. Please cross-link here.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Follow up here #777790: file.module uses undocumented behaviors.unattach

spyderboy’s picture

spyderboy CreditAttribution: spyderboy commented
Status: Fixed » Needs review
spyderboy’s picture

spyderboy CreditAttribution: spyderboy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.