Every time I do a cvs update on head, and settings.php gets overwritten I end up back in the installer when I goto my test site. I enter the database data again, and then it forwards me to a page telling me to edit my settings php, or empty my database.....

I think the most common reason people will over write their settings php is on an untar upgrade. And they are most likely updating their site... So maybe we should add some text to the affect that if they're upgrading they should visit update.php... attached is a patch.

CommentFileSizeAuthor
#7 installer-to-update.patch_1.txt975 bytesdopry
#6 Screenshot-installer-dberr-patched.png82.23 KBdopry
#5 Screenshot-installer-dberr.png77.95 KBdopry
#1 installer-to-update.patch_0.txt968 bytesdopry
installer-to-update.patch.txt1.13 KBdopry
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dopry’s picture

dopry CreditAttribution: dopry commented
FileSize
installer-to-update.patch_0.txt968 bytes

UnConed, thought saying 'the update script' would be better than update.php. I also split the options into individual

tags... A

    may be better. I also stripped out my password['#required'] => FALSE. Thats for another patch.
dopry’s picture

dopry CreditAttribution: dopry commented

that markup was p and ul respectively.

dopry’s picture

dopry CreditAttribution: dopry commented
Status: Active » Needs review

umm yeah, and status...

additional.. The current state of the error page(pre-patch) is if your settings.php is works, and you have a database.

It suggests you update your settings.php db_name, or empty your database. If you check you settings.php verify that it is correct and reload the install.php page, its show the same two options and you've eliminated the settings.php issue, the remaining option is... empty your database....

I don't think we should suggest a user nuke their database if it exists and it can be connected to...

This patch basically adds a third option which is update.php...

--dopry, the pendantic

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work

The generated HTML doesn't look 100% valid to me. Some strings have paragraph-tagss, others have not.

Care to provide a screenshot (before and after)? Does would help people review the proposed changes. Thanks!

dopry’s picture

dopry CreditAttribution: dopry commented
FileSize
Screenshot-installer-dberr.png77.95 KB

Here's a screen shot of the original error.

dopry’s picture

dopry CreditAttribution: dopry commented
FileSize
Screenshot-installer-dberr-patched.png82.23 KB

Here's a screenshot with the patch...

dopry’s picture

dopry CreditAttribution: dopry commented
FileSize
installer-to-update.patch_1.txt975 bytes

And here's a patch with the <p> tags fixed up.

dopry’s picture

dopry CreditAttribution: dopry commented
Status: Needs work » Needs review

and here it is set back to needing review... talk about incrementals.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed a modified version to CVS. :)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)