I found a minor url error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

Assigned: Unassigned » dww
FileSize
2.11 KB

but wait, there's more. ;) admin/menu is now admin/build/menu, too. attached patch re-rolls previous patch with my fixes for admin/menu (which i was about to submit separately, but i found this issue, first). ;)

dww’s picture

Status: Needs review » Fixed

in IRC UnConed said i should commit. applied to HEAD (revision 1.97).

moshe weitzman’s picture

Status: Fixed » Reviewed & tested by the community

feel free to commit, derek. i know you have enbouh privs :)

note that + return 'admin/build/menu'; is not really desired. better to just stay on whatever page issued t\he form submit.

dww’s picture

Status: Reviewed & tested by the community » Fixed

moshe: looks like we were replying at almost the same time... ;) i had already committed.

note that + return 'admin/build/menu'; is not really desired. better to just stay on whatever page issued t\he form submit.

keep in mind, there's the confirm page. so, if i take out that return, you just end up back on the confirm page. not sure how to remember where we were when the user first clicked on "reset menus". if there's an easy way to deal with that via get/set_destination() (which i've never looked too closely at), let's talk about it in a new issue with a separate patch. the task at hand (fixing for the admin reorg) is done with the existing behavior, so let's leave this issue fixed/closed.

thanks,
-derek

Anonymous’s picture

Status: Fixed » Closed (fixed)
drewish’s picture

Version: » 7.x-1.x-dev
Status: Closed (fixed) » Needs review
FileSize
1.56 KB

here's a couple of small fixes to use the new urls

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

anyone authorized is welcome to commit this.

dww’s picture

Status: Reviewed & tested by the community » Fixed

applied to HEAD. thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)