Escaped me during #629794: Scaling issues with batch API :

Comment says :

// We need the full $form_state when either:
// - Some submit handlers were saved to be called during batch
//   processing. See form_execute_handlers().
// - The form is multistep.

and the corresponding code is

if ($batch['has_form_submits'] || !empty($form_state['rebuild']) || !empty($form_state['storage'])) {
  $batch['form_state'] = $form_state;
}

After #634440: Remove auto-rebuilding magic for $form_state['storage'] and a couple fellow $form_state / rebuild issues, !empty($form_state['storage']) does not indicate a multistep form, only !empty($form_state['rebuild']) does, so the 3rd clause in the test can go away.

CommentFileSizeAuthor
batch_form_state.patch.patch1.29 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

(oops, a trailing space fix slipped in - no biggie...)

fago’s picture

Component: taxonomy.module » forms system
Status: Active » Needs review

Well the storage rebuild automation (and storage) are gone, so no need to check this any more. And this damn whitespace needs to go to anyway, the earlier the better ;)

Let's let the test bot run.

fago’s picture

Status: Needs review » Reviewed & tested by the community

Thanks bot.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.