Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Escaped me during #629794: Scaling issues with batch API :
Comment says :
// We need the full $form_state when either:
// - Some submit handlers were saved to be called during batch
// processing. See form_execute_handlers().
// - The form is multistep.
and the corresponding code is
if ($batch['has_form_submits'] || !empty($form_state['rebuild']) || !empty($form_state['storage'])) {
$batch['form_state'] = $form_state;
}
After #634440: Remove auto-rebuilding magic for $form_state['storage'] and a couple fellow $form_state / rebuild issues, !empty($form_state['storage'])
does not indicate a multistep form, only !empty($form_state['rebuild'])
does, so the 3rd clause in the test can go away.
Comment | File | Size | Author |
---|---|---|---|
batch_form_state.patch.patch | 1.29 KB | yched | |
Comments
Comment #1
yched CreditAttribution: yched commented(oops, a trailing space fix slipped in - no biggie...)
Comment #2
fagoWell the storage rebuild automation (and storage) are gone, so no need to check this any more. And this damn whitespace needs to go to anyway, the earlier the better ;)
Let's let the test bot run.
Comment #3
fagoThanks bot.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.