Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.On the settings page for an image field, there should be an 'x' between the two max/min resolution fields and 'pixels' after them, but there isn't (see 1st screenshot).
Looking at the code on line 122 of image.field.inc in the core image module, there isn't a function set for '#theme_wrappers' for either the 'x' or 'y' field, so I take it that the function for the parent 'max_resolution' should be used; however, the theme_form_element() function doesn't account for child fields...
The other alternative is to simply add 'form_element' to each field's '#theme_wrappers' setting, but this puts a div around each field and therefore displays the fields on separate lines (see 2nd screenshot)...
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 758996-suffix_for_resolution_fields-4.patch | 2.81 KB | stBorchert |
| #4 | 758996-suffix_for_resolution_fields-4.png | 33.51 KB | stBorchert |
| image_field_suffixes_2.png | 12.81 KB | BWPanda | |
| image_field_suffixes.png | 12.03 KB | BWPanda | |
Comments
Comment #1
aaron CreditAttribution: aaron commentedgood catch. seems as though (to me) that it should also specify width x height, as that won't be obvious to everyone.
Comment #2
BWPanda CreditAttribution: BWPanda commentedI think it mentions 'width' and 'height' in the description below the fields, it just got cut off in my screenshots...
Comment #3
stBorchertWhile working on #686528: User picture dimensions not validated: Split user picture dimensions into two fields I noticed the same behavior.
Looking into #523478-38: WIDTH x HEIGHT text (the original issue for the dimension fields) I saw that we previously used
and floated the fields.
This was changed while getting image.module into core to
'#theme_wrappers' => array('form_element'),for the surrounding field and'#theme_wrappers' => array(),for both input fields.Problem: without a theme function no additional information such as
#title,#field_suffixorfield_prefixis rendered.Solution: we need either a new theme function for inline elements or we roll back the code and remove the
#theme_wrapperproperty from these fields.Thoughts?
Comment #4
stBorchertCreated the patched the rolled back the use of
'#theme_wrappers' => array().Comment #5
dawehnerLooks fine.
And it works fine.
Comment #6
webchickHm. Strange. I wonder why this would've been done to begin with. The new code certainly looks much more sane.
Committed to HEAD. If this breaks anything, let's make sure we get some tests in. :P