Overlay should use events instead of single callbacks

Sounds like a good idea. Patch looks good, applies cleanly, and doesn't break anything, so rtbc. :)

Looks good.

+++ modules/overlay/overlay-parent.js	24 Apr 2010 10:12:05 -0000
@@ -319,6 +327,9 @@
 
+  // Allow other scripts to respond to this event.
+  $(document).trigger('drupalOverlayBeforeLoad');

Do we need this event?

Committed to CVS HEAD. Thanks.

This isn't good:

from Drupal.overlay.load:

  self.$iframe
    .bind('load.overlay-event', function () {

Since the iframe content get's (re)loaded multiple times, this also means that everytime the iframe loads new content, a new load event is bound.

So after 3 "overlay loads", load.overlay-event has been bound 3 times, and as a consequence at the third iframe load 'drupalOverlayLoad' is called 3 times.

Solution could either be using once() or unbinding right before binding ($something.unbind().bind();)

Sorry, isn't that the expected behavior?

I'm sorry, I misunderstood the problem. I see. Patch coming.

Here's a patch, just uses .once to avoid attaching it multiple times.

Looks good. Nice catch Kiphaas7.

Committed to HEAD. Thanks!