I just updated my local clean cvs HEAD installation. TortoiseCVS log:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In Z:: G:\Program Files\TortoiseCVS\cvs.exe -q -z9 update -d -P
CVSROOT=:pserver:anonymous@drupal.org:/cvs/drupal

P CHANGELOG.txt
RCS file: /cvs/drupal/drupal/includes/conf.php,v
retrieving revision 1.28
retrieving revision 1.29
Merging differences between 1.28 and 1.29 into conf.php
M includes/conf.php
P includes/database.inc
P includes/database.mysql.inc
P includes/database.pear.inc
P modules/comment.module
P modules/system.module
P modules/user.module

Success, CVS operation completed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ran update.php to update from update_83 to the latest. No errors displayed during the update, but browsing to /admin/syndication/news gives:

user error: Table 'drupal-cvs.aggregator_feed' doesn't exist
query: SELECT f.*, COUNT(i.iid) AS items FROM aggregator_feed f LEFT JOIN aggregator_item i ON f.fid = i.fid GROUP BY f.fid, f.title, f.url, f.refresh, f.checked, f.link, f.description, f.etag, f.modified, f.image ORDER BY f.title in d:\www2\drupal-cvs\includes\database.mysql.inc on line 100.

user error: Table 'drupal-cvs.aggregator_category' doesn't exist
query: SELECT * FROM aggregator_category ORDER BY title in d:\www2\drupal-cvs\includes\database.mysql.inc on line 100.

It seems update_85 fails to rename the tables, then fails to flag the error. phpMyAdmin confirms I still have tables 'bundle', 'feed' and 'item'. The 'sequences' table was also untouched. Re-running update.php tells me there are no updates to perform.

Comments

marky’s picture

merde :(

update_84 failed too - no column 'help' in my vocabulary table.

marky’s picture

MySQL 4.0.12-nt on w2k.

After a little prodding around I found that print_r($GLOBALS['db_type']) returns empty. In fact, print_r($GLOBALS) has only 2 mentions of MySQL, one in the path, the other in $GLOBALS['db_url'].

Commenting out the check for MySQL in both update functions allowed the updates to proceed. This was safe for me as I *know* I'm running MySQL.

It may be safer to check $GLOBALS['db_url'] in updates.inc to determine the db type. Thoughts?

Dries’s picture

Fixed by patch #7575.

Anonymous’s picture