field.module#list_field_formatter_view() includes this code: $output = field_filter_xss($value);.

However $value is not defined in this function.

It should probably be $output = field_filter_xss($delta); instead.

CommentFileSizeAuthor
#7 list_formatter.patch771 bytesfgm
#1 list_formatter.patch763 bytesfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Active » Needs review
FileSize
list_formatter.patch763 bytes

Suggested patch.

Status: Needs review » Needs work

The last submitted patch, list_formatter.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs work » Needs review

No comprendo: the error is
- "The test did not complete due to a fatal error."
- "Completion check"
- "options.test 291"
- "OptionsWidgetsTestCase->testSelectListMultiple()"

But in the latest version (1.10 of options.test), there is no test at line 291 and no test called "Completion check" in OptionsWidgetsTestCase::testSelectListMultiple()

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented

OK, so line 291 is where testSelectListMultiple() starts, and "Completion check" is within DrupalWebTestCase.

Anyway, tested again on the latest head, and it works, so requesting re-test.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented

#1: list_formatter.patch queued for re-testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Needs work

$value should be $item['value']

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs work » Needs review
FileSize
list_formatter.patch771 bytes

Rerolled.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Thks !

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.