Revealed in #730754-8: CSS coding standards: No !important in core/contrib modules, ONLY IN THEMES

The html.js CSS selector

- should mainly be used to enable/disable elements depending on whether JS is enabled or not

- should NOT be used to style them entirely different. (unless we talk about vertical tabs :P)

This patch cleans up fieldset styling even more.

CommentFileSizeAuthor
#5 helpScreenAddShortcut.png236.94 KBaspilicious
#3 drupal.html-js-fieldset.3.patch3.96 KBsun
#2 noSpaceCollapsed.png162.47 KBaspilicious
drupal.html-js-fieldset.0.patch3.84 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

i'll test this

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
noSpaceCollapsed.png162.47 KB

Can you add some space between a button and the fieldset when collapsed?

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
drupal.html-js-fieldset.3.patch3.96 KB

Thanks for testing! That revealed yet another ugliness. Now fixed :)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Can someone give an IE6 review?

I'll do the rest :)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
helpScreenAddShortcut.png236.94 KB

First layout issue that hits my eye...

Dunno if it's related with this patch.
But I see the add shortcut button for a second on the wrong place in ff 3.5.8
After that one milisecond it's gone

Same issue in opera 10.50

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

That's unrelated to this patch, as this patch only changes CSS for fieldsets.

I've tested IE6 in all themes and there is no difference between before and after this patch.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

I'll open issues for those other problems.
This one is rtbc.

casey’s picture

casey CreditAttribution: casey commented

#367367: Overflow CSS causing issues.

casey’s picture

casey CreditAttribution: casey commented

Can we get a commit here? Those CSS issues needs full re-reviewing in all browsers when things change in between.

Still looking good though.

Jacine’s picture

Jacine
she/her
Location New York
CreditAttribution: Jacine commented

RTBC + 1

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

+2 :p

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.