Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Considering this is an admin screen, where contrib modules often add wide tables, the behavior of Overlay hiding overflow is not good. You can see this with the Media module, if you install that module and navigate to Structure > Media Types > Manage (Image) Display (or any of the types). Seems as though the overlay page should be set to overflow: auto.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | overlay-widecontent.patch | 480 bytes | casey |
| #8 | 739420.patch | 977 bytes | RobLoach |
| #7 | 739420.patch | 976 bytes | RobLoach |
| #2 | overlay-fix-clip.739420.2.patch | 676 bytes | aaron |
| overlay-no-scroll.png | 27.88 KB | aaron | |
Comments
Comment #1
aaron CreditAttribution: aaron commented(Click through to see the full image if it's cut off on your browser.)
Comment #2
aaron CreditAttribution: aaron commentedthis patch fixes that particular problem, but unfortunately adds a vertical scrollbar to all pages....
Comment #3
aaron CreditAttribution: aaron commentednot sure if this would technically be an Overlay problem or a Seven theme. tagging for both, and folks can switch if it's more appropriate (though i would argue it's an overlay problem, since the seven theme doesn't depend on overlay, and in fact works fine with overlay turned off).
Comment #4
aaron CreditAttribution: aaron commentedactually, marking for review, because this is the only way short of js magic i can think of to make wide tables work in overlay.
Comment #5
cosmicdreams CreditAttribution: cosmicdreams commented#2: overlay-fix-clip.739420.2.patch queued for re-testing.
Comment #6
RobLoachShouldn't this go in the Overlay CSS rather than Seven's CSS?
Regarding the Manage Display page, see #553298: Redesign the 'Manage Display' screen.
Comment #7
RobLoachComment #8
RobLoachPesky tabs.
Comment #9
aspilicious CreditAttribution: aspilicious commentedProbably fixed by this: #668640: Overlay shouldn't be based on jQuery UI Dialog
Comment #10
casey CreditAttribution: casey commentedWide tables will be fully visible now. But it would be much nicer if overlay's width stretches along. This should be possible now since the whole overlay is inside overlay's iframe.
Comment #11
casey CreditAttribution: casey commentedMarking active as we don't have no previous patches that apply. To get this patch fixed we might try to alter overlay-child.css, so the overlay stretches along with unbreakable wide content (like tables).
Comment #12
aspilicious CreditAttribution: aspilicious commentedWhat will happen if it can't be stretched enough?
Comment #13
casey CreditAttribution: casey commentedCurrently if the tables are wider than user's screen a horizontal scrollbar will appear. The overlay background however won't stretch along; the tables will overflow the overlay.
It should be possible to make the overlay stretch along. It will however be tricky to get it working along with the min-width (in pixels) and width (88%); we might need some Javascript.
(I do have an exam next week and really shouldn't be working on Drupal right now. If nobody has gotten this to work then, I will give it a try)
Comment #15
casey CreditAttribution: casey commentedWohoo turns out to be pretty easy.
http://www.quirksmode.org/css/display.html#table
display:table doesn't work in IE6/IE7 so in those wide tables still overflow the overlay but its not unusable.
Safari 3 and Chrome 1 require elements with display: table and display: table-row to show the cells correctly. The other browsers, including Safari 4 and Chrome 2, don't. Not sure how it looks in in Safari 3 or Chrome 1, but nobody uses those browsers anymore so that shouldn't be a problem.
Comment #16
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.