make filter tips link themeable [#72797]

Categorizing this as a bug, since it's a UI problem:

See this forum topic- an example of something that should be simple is way too hard:

The basic problem is users clicking on the filter tips link and then losing the post they composed. Thus, being able to have this link open in a new window is desireable.

existing code:

  $extra = l(t('More information about formatting options'), 'filter/tips');

could be changed to make this link themeable, such as:

$extra = theme('filter_tips_more_info');

...

function theme_filter_tips_more_info () {
  return l(t('More information about formatting options'), 'filter/tips');
}

Or (alternatively) have this link open in a new window by default, or provide some other way to configure it.

Comment	File	Size	Author
#7	theme_filter_tips_6.diff.txt	1 KB	beginner
#5	theme_filter_tips_5.diff	1009 bytes	pwolanin
#5
#1	theme_filter_tips_1.txt	5.63 KB	pwolanin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pwolanin CreditAttribution: pwolanin commented 9 August 2006 at 01:26

Title:	open filter tips link in a new window, or add theme function	» make filter tips link themeable
Version:	4.7.2	» x.y.z
Status:	Active	» Needs review

File	Size
theme_filter_tips_1.txt	5.63 KB

Attached patch implements change as suggested above, and does a little code cleanup by removing some of the markup from inside t-ified strings. Also removes the unused $extra parameter from function theme_filter_tips.

Comment #2

beginner CreditAttribution: beginner commented 9 September 2006 at 07:30

bookmarking: I'll review this early next week.
Can you just make sure your patch still applies?

Comment #3

beginner CreditAttribution: beginner commented 22 September 2006 at 04:16

Status:

Needs review

» Needs work

oops. Sorry for the delay.

Why did you change the formatting for all the strings? As far as I can see, the text has not changed at all, and it is not relevant to the issue at hand. Doing so also forces the translator to re-translate strings they have already translated. I think the guidelines say that html is allowed in long strings, but if you really think the <p> should be extracted from the strings, open a separate issue. But the translators will not be happy to have to re-translate all of those strings when the end result is the same.

Can you reroll a patch for current HEAD, without any of the string changes (both in filter_help() and in filter_admin_format_form()).