According to http://benalman.com/projects/jquery-bbq-plugin/ this version is compatible with jQuery 1.3.2, 1.4.1 and 1.4.2, so we don't need to wait for the jQuery 1.4 patch to land.

Quickly tested it against overlay, which seems to work.

CommentFileSizeAuthor
#11 jquery-bbq-whitespace.patch863 byteststoeckler
#7 jquery-bbq-v2.patch9.09 KBaspilicious
#5 jquery-bbq.patch8.47 KBcasey
#3 jquery-bbq.patch7.5 KBcasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ben_alman’s picture

ben_alman CreditAttribution: ben_alman commented

You should definitely upgrade jQuery BBQ to the latest version, because the version you're currently using is probably not compatible with jQuery 1.4.2+ due to a jQuery events API change after 1.4.1.

The latest version of jQuery BBQ is both backwards- and forwards- compatible, so it will work with 1.3.2+.

Also, when you do update to jQuery 1.4, upgrade to *at least* 1.4.2, because 1.4 and 1.4.1 had some serious issues (1.4.3, which isn't out yet, will fix a few 1.4.2 issues as well).

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Active

Definitely a must! I don't see a patch though :-( .

casey’s picture

casey CreditAttribution: casey commented
Status: Active » Needs review
FileSize
jquery-bbq.patch7.5 KB

Oww I probably forgot to attach.

ben_alman’s picture

ben_alman CreditAttribution: ben_alman commented

BTW, jQuery BBQ now has built-in support for not escaping certain characters in fragments, which you guys might find useful since you have custom code written on top of BBQ that does just that.

http://benalman.com/code/projects/jquery-bbq/docs/files/jquery-ba-bbq-js...

casey’s picture

casey CreditAttribution: casey commented
FileSize
jquery-bbq.patch8.47 KB

Great!

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Needs work

Probably want to update system_library()...

  // jQuery BBQ plugin.
  $libraries['jquery-bbq'] = array(
    'title' => 'jQuery BBQ',
    'website' => 'http://benalman.com/projects/jquery-bbq-plugin/',
    'version' => '1.0.2',
    'js' => array(
      'misc/jquery.ba-bbq.js',
    ),
  );
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
jquery-bbq-v2.patch9.09 KB

Like this?

casey’s picture

casey CreditAttribution: casey commented

Yes, can we get a RTBC?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Fixed » Needs review
FileSize
jquery-bbq-whitespace.patch863 bytes

Patch introduced some whitespace.
Attached patch also fixed the other whitespace issue in that file.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

srry for that :s

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented

still applies.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.