Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Adds a conditional check on colspan attribute when generating the header count for the empty message.
Comment | File | Size | Author |
---|---|---|---|
#9 | 722978-9.patch | 2.4 KB | duellj |
#7 | theme-invalid-empty-column-count-4.patch | 913 bytes | Alan D. |
#5 | theme.inc-3.patch | 885 bytes | Alan D. |
#3 | theme-2.inc_.patch | 911 bytes | Alan D. |
theme.inc_.patch | 913 bytes | Alan D. | |
Comments
Comment #1
Alan D. CreditAttribution: Alan D. commentedSorry, steps to reproduce. Simply have a look at a empty vocab listing in "admin/structure/taxonomy".
Comment #3
Alan D. CreditAttribution: Alan D. commentedLets see if ConText can save the correct line endings...
Comment #5
Alan D. CreditAttribution: Alan D. commentedOK, ConText convert filter run a couple times...
Comment #7
Alan D. CreditAttribution: Alan D. commentedDuh. Wrong context.
Comment #8
effulgentsia CreditAttribution: effulgentsia commentedRelated but different: #720202: theme_table doesn't use thead with empty cells. Please add a test.
Comment #9
duellj CreditAttribution: duellj commentedFixed spelling error in last patch, and also updated testThemeTableWithEmptyMessage to include a check for correct colspan in empty message when header has a colspan.
Comment #10
alienresident CreditAttribution: alienresident commentedReview this patch and it passed the simple test code looks good to me.
Very latest patch is mostly typos.
Comment #11
jrbeemanPatch reviewed and simpletest ran successfully. Looks great.
Comment #12
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!