template_preprocess_node makes an useless comprobation [#705912]

As long as function node_view:

// We don't need duplicate rendering info in node->content.
  // We don't need duplicate rendering info in node->content.
  unset($node->content);

  $build += array(
    '#theme' => 'node',
    '#node' => $node,
    '#view_mode' => $view_mode,
  );

$node->content won't be defined in $variables['elements']['#node'] so this comprobation is uselesS:

  if (!empty($node->in_preview)) {
    unset($node->content['links']);
  }

Comment	File	Size	Author
#3	unneeded-if.patch	817 bytes	bleen
#3
#2	template_preprocess_node.patch	690 bytes	jherencia
#2
	template_preprocess_node.patch	711 bytes	jherencia

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 February 2010 at 02:50

Status:

Needs review

» Needs work

The last submitted patch, template_preprocess_node.patch, failed testing.

File	Size
template_preprocess_node.patch	690 bytes

Comment #3

bleen CreditAttribution: bleen commented 19 September 2010 at 19:15

File	Size
unneeded-if.patch	817 bytes

I can confirm that when $node->in_preview == TRUE, there is no $node->content so this check is unnecessary

reroll...

Comment #4

19 September 2010 at 21:30

Status:

Needs review

» Needs work

The last submitted patch, unneeded-if.patch, failed testing.

Comment #5

tobiasb

German

Berlin

CreditAttribution: tobiasb commented 19 September 2010 at 21:57

Status:

Needs work

» Needs review

#3: unneeded-if.patch queued for re-testing.

Comment #6

moshe weitzman CreditAttribution: moshe weitzman commented 20 September 2010 at 00:30

Status:

Needs review

» Reviewed & tested by the community

The code we are removing does serve a purpose. Namely, it tries to remove node links during a Preview. That’s done because you can't actually add a comment and so on to a node thats not been created yet. Seems like the code is acting on the wrong variable though.

I'm fine with removing this, since removing node links during Preview is pretty edge case anyway.