If there are a large number of terms in a vocabulary that would require more than one line to fit in the div pop-tags, they will not break properly, and the div will be extended to the right. The attached patch solves this by adding a blank space at the end of all inner tag-popular divs.

Comments

portulaca’s picture

StatusFileSize
new510 bytes

I can confirm the patch above helps with Popular tags.

But to stop the problem from appearing you need to do the same for "tag-tags" too. I'm attaching the patch.

btw why isn't this part themed through Drupal? We can't override the output easily, we have to hack the js file.

dragonwize’s picture

I don't really understand what the issue here is. Can someone please explain more or post a screen shot of the issue that you are trying to solve?

@portulaca: It is ran through the Drupal theme system so that you do not have to hijack or modify any of the modules files. See http://drupal.org/node/171213

portulaca’s picture

StatusFileSize
new190.76 KB

I didn't know about that! Thanx for the clarification, it's very useful.

The problem is probably about display:inline that is applied to the tags, but there is no space between them so they all appear to be one long word so it doesn't wrap. Screenshot attached, the tags widen their container so it leaks to the texture area instead of wrapping to the next line.

I still think this should be patched since you'll always encounter this problem, if you set it to display:inline as default it makes sense to have the space between tags so they wrap if they reach the end of the container.

Users can float them to avoid this problem but that layout introduces more problems, I favor the inline approach.

dragonwize’s picture

Title: pop-tags div doesn't wrap properly » div tags do not wrap properly
Version: 6.x-1.5 » 6.x-1.x-dev
Status: Active » Fixed

Thank you. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.