Improve RDF tests [#691692]

Some tests in rdf.test are not very robust and do not contain a full xpath expression.

    $this->assertRaw('property="dc:title"');

It seems we're also missing a test for the relation between a comment and its parent node and parent comment. Same for the node title in full node mode (drupal_add_html_head($element, 'rdf_node_title');)

Comment	File	Size	Author
#12	rdf_improve-test_691692-8.patch	6.33 KB	cwgordon7
#12
#10	rdf_improve-test_691692-6.patch	6.33 KB	Stefan Freudenberg
#10
#9	rdf_improve-test_691692-5.patch	6.35 KB	Stefan Freudenberg
#9
#7	rdf_improve-test_691692-4.patch	6.36 KB	Stefan Freudenberg
#7
#5	rdf_improve-test_691692-3.patch	6.35 KB	Stefan Freudenberg
#5
#2	rdf_improve-test_691692-2.patch	4.06 KB	linclark
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 21 January 2010 at 16:35

Assigned:

Unassigned

» linclark

Unless you're already working on this, I can work on this tomorrow.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 24 January 2010 at 23:57

File	Size
rdf_improve-test_691692-2.patch	4.06 KB

This patch replaces all the assertRaw statements with XPath checks. It also checks the title in full node view by checking the content attribute of the meta tag.

I am going to break the test for the relation between a comment and its parent node and parent comment into a separate issue because that test will fail until some other patches are committed.

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 25 January 2010 at 00:03

Status:

Active

» Needs review

#694314: RDF tests for parent/comment relationship has been created.

Comment #4

scor CreditAttribution: scor commented 7 February 2010 at 16:13

Status:

Needs review

» Needs work

#694314: RDF tests for parent/comment relationship now duplicate since we now have proper RDFa markup for comment body. Tests can be merged with this issue.

Comment #5

Stefan Freudenberg CreditAttribution: Stefan Freudenberg commented 21 April 2010 at 05:41

File	Size
rdf_improve-test_691692-3.patch	6.35 KB

Added tests for the relation between a comment and its parent node and parent comment and removed trailing whitespace.

Comment #6

scor CreditAttribution: scor commented 21 April 2010 at 05:55

+++ modules/comment/comment.test	21 Apr 2010 05:39:21 -0000
@@ -1166,6 +1166,10 @@ class CommentRdfaTestCase extends Commen
+    $result = $this->xpath("id('comments')//div[@class='comment' and position()=0]//span[@rel='sioc:reply_of' and @resource=:node]", array(':node' => url("node/{$this->node1->nid}")));
+    $this->assertEqual(1, count($result), t('Assert RDFa markup referring to the node is present.'));
+    $result = $this->xpath("id('comments')//div[@class='comment' and position()=0]//span[@rel='sioc:reply_of' and @resource=:comment]", array(':comment' => url('comment/1#comment-1')));
+    $this->assertFalse($result, t('Assert no RDFa markup referring to the comment itself is present. '));

Let's bundle this first hunk into the new function you create afterwards.

Powered by Dreditor.