Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is a typo in the blog.module: a href='@blog''
Comment | File | Size | Author |
---|---|---|---|
#10 | apostrophe-691456-3.patch | 1.54 KB | Boobaa |
#8 | apostrophe-691456-2.patch | 32.3 KB | Boobaa |
#5 | apostrophe-691456-1.patch | 32.3 KB | Boobaa |
Comments
Comment #1
BoobaaThere are quite a few other places in core with
<a href='foo'>
- will try to patch'em all soonish.Comment #2
zserno CreditAttribution: zserno commentedThis is an excellent opportunity for new contributors, so tagging it with Novice.
Comment #3
qasimzee CreditAttribution: qasimzee commentedI am fresh to drupal open source. Can we attach our patch on the same page with comment ?
I have read some pages but unable to find this information.
Comment #4
BoobaaPatch is on the way, i'm already working on it; expect results in ~10 mins.
Comment #5
BoobaaSorry for the delay, CVS is like a snail here.
I haven't touched
jquery.js
norcomment.test
as I don't know whether it's a bug there as well.Comment #6
Heine CreditAttribution: Heine commentedDid you try the patch?
This simply won't parse:
As single quotes are perfectly valid as attribute value delimiters, why not just use '@blog' ? If you do want to use double quotes, either escape (\") them, or use a single quote delimited string and escape the lone single quote (\') after site
Comment #7
zserno CreditAttribution: zserno commented@qasimzee: Welcome to Drupal :)
So when someone creates a patch then writes a comment with the attached .patch file. (Below the comment's textbox you can see a 'File attachments' form element.)
Also it's a common practice to change the issue status to CNR (code needs review) whenever a new patch is attached so the test bot will automatically run its tests to find out if that patch breaks something in Drupal's core.
Comment #8
Boobaa@Heine in #6: Thanks for pointing me at that tyop; look's like I should set up my own testbot environment. :S
Corrected (and tested) patch is attached.
Comment #9
zserno CreditAttribution: zserno commented@Boobaa: I really don't understand why you're changing all single quotes to double ones. As Heine already mentioned above, single-quoted attribute values are perfectly ok. Source: http://dev.w3.org/html5/html-author/.
So I'd suggest focusing only on the original typo.
Comment #10
BoobaaAttached is the patch which solves OP, without disturbing the force more than needed. Sorry for the already-done disturbances.
Comment #11
Zoltán Balogh CreditAttribution: Zoltán Balogh commented#10 is OK
Comment #12
qasimzee CreditAttribution: qasimzee commented@zserno: Thanks a lot for your guidance
Comment #14
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!