Installation messages don't conform to Drupal path conventions

The folder may have been changed too, for example because the ./sites/default/files directory have been created there.

I may be missing something, but I don't think your comment fully addresses the issue: that is, by convention, Drupal tends to refer to subdirectories relative to Drupal root without the "./", except here. This leads to a little bit of confusion.

Attached is a patch that changes the display to the normal "settings/sitename/settings.php" format for path names. It keeps the pathnames without the "./" as a baseline, and adds DRUPAL_ROOT back when it needs them in the file_exists() conditional. This conforms to the way getting the current working directory is handled elsewhere.

Sorry, you are right. Somehow I missed that part of the problem.

Patch also works for me and looks fine.

Committed to CVS HEAD. Thanks.

This makes sense but it introduces an inconsistency since the rest of the installer still uses the "./" notation.

We at least would need to make a similar change in install_check_requirements(). There may be others too, but that is definitely one place where the "./" is used in the user interface.

This should fix install_check_requirements()

#9: installation_messages-689954-9.patch queued for re-testing.

We should be consistent in how we generate paths: in bootstrap.inc and the patch committed in #3, the method is to set path variables to the Drupal conventional path (without the "./") and add back DRUPAL_ROOT . "/" when we need it (e.g., for file_exists()).

However, in the patch in #9 there's:

+    $conf_path_name = conf_path(FALSE, TRUE);
+    $conf_path = './' . $conf_path_name;

A new variable shouldn't be introduced: $conf_path should be set to conf_path(FALSE, TRUE), and all existing instances of $conf_path should be replaced with DRUPAL_ROOT . "/" . $conf_path.