Toolbar.js is using the Drupal.admin namespace. No other module uses this, nor should toolbar. It can use some more cleaning but lets review this one first to keep things simple.

CommentFileSizeAuthor
#12 toolbar-remove-admin.patch1.12 KBjide
#7 toolbar-remove-admin_686670_7.patch3.64 KBmfer
#5 toolbar-remove-admin_686670_5.patch3.64 KBseutje
#1 toolbar-remove-admin_686670_1.patch3.3 KBmfer
toolbarcleanup.patch3.43 KBcasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfer’s picture

mfer CreditAttribution: mfer commented
FileSize
toolbar-remove-admin_686670_1.patch3.3 KB

The patch was almost there but Drupal.behaviors.admin should be Drupal.behaviors.toolbar. Using the admin on the end is a namespace mismatch. The attached patch changes that as well.

mfer’s picture

mfer CreditAttribution: mfer commented

Also note, the deeper something is nested in JavaScript the slower it is. By removing the extra layer of referencing there is an ever so small performance improvement.

seutje’s picture

seutje CreditAttribution: seutje commented

looks like u got em all in the code, but shouldn't u also change the comments?

/**
 * Implementation of Drupal.behaviors for admin.
 */
Drupal.behaviors.toolbar = {

/**
 * Collapse the admin toolbar.
 */
Drupal.toolbar.collapse = function() {
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Needs work
seutje’s picture

seutje CreditAttribution: seutje commented
Status: Needs work » Needs review
FileSize
toolbar-remove-admin_686670_5.patch3.64 KB

changed comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented 
+++ modules/toolbar/toolbar.js
@@ -1,18 +1,20 @@
 /**
- * Implementation of Drupal.behaviors for admin.
+ * Implementation of Drupal.behaviors for the toolbar.
  */

This should either state what the behavior is actually doing, or it simply needs to go. The former is preferred ;)

Powered by Dreditor.

mfer’s picture

mfer CreditAttribution: mfer commented
FileSize
toolbar-remove-admin_686670_7.patch3.64 KB

Updated the patch per Suns comments.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks good now - didn't test though. (hope you did ;)

mfer’s picture

mfer CreditAttribution: mfer commented

I did test it... works :)

seutje’s picture

seutje CreditAttribution: seutje commented

yay \o/

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Thanks. This is probably leftover from when yhahn made a Drupal 7 patch from Admin module.

Committed to HEAD.

jide’s picture

jide CreditAttribution: jide commented
Status: Fixed » Needs review
FileSize
toolbar-remove-admin.patch1.12 KB

There are some more strings to be changed in toolbar.module.
Correcting these fixes sticky tables.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.