Use basename not pretty name in theme_get_settings

Please roll a proper patch. Details at HOWTO: Create patches.

I think 'forum topic' is more accurate than 'forum'. The latter is a collection of forum topics. Can't we fix the template system instead?

First, this is hardly critical.

Then, what is broken exactly?
Here is an example of a forum node with the user picture:
http://www.reuniting.info/node/386

I recently set this very similar issue as fixed:
http://drupal.org/node/45070

What am I missing?

If something is really broken, cvs should be patched first and the fix backported.

setting 'critical' only for a missing picture will not get your patch committed faster ;)

Again, how to reproduce the error? I don't see any problems in my sites.

Also, if this is an API change, it'll only get into CVS, not 4.7 -- 4.7 is stable and will take no API changes unless they are critical security fixes.

I second beginner's comments. Please provide details (with source code if possible) of how you feel this is a bug, and stop marking issues critical that are not.

The problem is due to the $op arguement of _node_names function (node.module) is not well defined and there is conflict in 'name' and 'list' operation.

xtony, can you be more verbose about this? I'd like to understand the problem. Thanks, Tony!.

This seems like a fairly deep change for just user pictures. I'm wary of side effects.

Toggling post information is a similar mechanism. Does that work?

theme_get_settings() returns an associative array of settings. I don't think thats what we would want to use as the condition for an if statement.

The documentation for theme_get_setting() makes it seem like the right thing. Maybe the problem is that it seems that the post information ("Submitted by ...") needs to be showing for the picture to show?

From this code in phptemplate.engine

  if (theme_get_setting('toggle_node_info_' . $node->type)) {
    $variables['submitted'] =  t('Submitted by %a on %b.', array('%a' => theme('username', $node), '%b' => format_date($node->created)));
    $variables['picture'] = theme_get_setting('toggle_node_user_picture') ? theme('user_picture', $node) : '';
  }

it is clear that the current settings needed to get user pictures in forum nodes is to enable

1) Display post information on forum topic
2) User pictures in posts

If you want user pictures in posts to be sufficient take the $variables['picture'] = ... out of the if (theme_get_setting('toggle_node_info_' . $node->type)) clause.

Oke, I see what you mean (though the setting toggles 'toggle_node_info_forum'). Since I was already mucking with the theme_settings code, I'll look into it further.

The reason why everything works is because of system_theme_settings (system.module: 1043)

foreach ($node_types as $type => $name) {
        $form['node_info']["toggle_node_info_$type"] = array('#type' => 'checkbox', '#title' => $name, '#default_value' => $settings["toggle_node_info_$type"]);
      }

where toggle_node_info_forum is defined in the theme settings form and saved upon submit.

This is of course inconsistent. Attached patch modifies theme_get_settings to use the node $key as node type.

And a patch against a fresh checkout of the 4.7 branch. The original title doesn't reflect the issue accurately; user pictures display fine in (forum) nodes.

Last patch looks good to me. Will commit unless someone objects.

Great collaboration folks! And xtony, welcome on board. ;)

Committed to HEAD.

also to 4.7.